Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360780 - [soap][api] allow subclasses to override creation of HttpMethod instances
Summary: [soap][api] allow subclasses to override creation of HttpMethod instances
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 3.7   Edit
Assignee: Robert Munteanu CLA
QA Contact:
URL:
Whiteboard:
Keywords: api, contributed, plan
Depends on:
Blocks:
 
Reported: 2011-10-13 04:45 EDT by Robert Munteanu CLA
Modified: 2012-03-21 12:15 EDT (History)
0 users

See Also:

Attachments
patch (2.12 KB, patch)
2011-10-13 04:46 EDT, Robert Munteanu CLA 		no flags Details | Diff
updated patch (2.13 KB, patch)
2011-10-13 06:27 EDT, Robert Munteanu CLA 		no flags Details | Diff
mylyn/context/zip (1.50 KB, application/octet-stream)
2011-10-13 06:34 EDT, Steffen Pingel CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Munteanu CLA 2011-10-13 04:45:01 EDT 
When using the SoapHttpSender, it is useful to be able to override the HttpMethod instances created. These instances have direct access to the writing of the request and reading of the response.

One use case is intercepting a malformed response and infering possible error causes. The handling is connector-specific and tricky, especially since Axis 1.4 has pretty unfriendly error messages for malformed input.

Another use case is intercepting content and cleaning it up in case a proxy inadvertently rewrites it.
Comment 1 Robert Munteanu CLA 2011-10-13 04:46:17 EDT 
Created attachment 205103 [details]
patch
Comment 2 Steffen Pingel CLA 2011-10-13 06:08:05 EDT 
Thanks for the patch! The suggested changes looks good. One minor suggestion for improvement: Please rename newPostMethod() and newGetMethod() to createPostMethod() and createGetMehthod() to make it more consistent with similar factory methods. If you attach an updated patch I'll apply that to master right away.
Comment 3 Robert Munteanu CLA 2011-10-13 06:27:09 EDT 
Created attachment 205111 [details]
updated patch

Renamed new*Method to create*Method
Comment 4 Steffen Pingel CLA 2011-10-13 06:34:01 EDT 
Excellent! I have applied the patch to master.
Comment 5 Steffen Pingel CLA 2011-10-13 06:34:03 EDT 
Created attachment 205112 [details]
mylyn/context/zip