Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360726 - Ctrl-Shift-Up/down fail to work properly
Summary: Ctrl-Shift-Up/down fail to work properly
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Editor (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.4 M1   Edit
Assignee: Mihai Sucan CLA
QA Contact:
URL: https://github.com/mihaisucan/orion.c...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-12 16:29 EDT by Mihai Sucan CLA
Modified: 2011-12-01 17:00 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Sucan CLA 2011-10-12 16:29:49 EDT 
(cross-posting from https://bugzilla.mozilla.org/show_bug.cgi?id=687577 )

STR:

1. Load http://orion.eclipse.org/examples/textview/demo.html and pick the Java/JavaScript file.
2. Put the caret a few lines down into the code, and use Ctrl+Shift+Left to extend the selection. (ctrl-shift-left to select backwards, word-by-word)
3. When you have selected a few lines, start pressing Ctrl+Shift+Up (to select lines upwards).  The selection isn't extended towards up, it seems that part of it are unselected at the bottom.

Expected result: select whole-lines upwards/downwards.

This seems to only affect Linux users.
Comment 1 Mihai Sucan CLA 2011-10-13 06:29:57 EDT 
I have a fix for this bug:

https://github.com/mihaisucan/orion.client/tree/bug-360726

Please review the patch and let me know if there are any changes needed before this code can be pushed into the Orion repo. Thank you!

Fix explanation: on Mac/Windows systems Ctrl-Shift-Up/Down keys do nothing, but on Linux (with gedit from Gnome) the whole line is selected upwards/downwards. This patch implements the desired behavior for Linux users.
Comment 2 Felipe Heidrich CLA 2011-10-13 17:11:34 EDT 
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=340e7e4018ac5e50e8954930060bd080110b5602

Awesome, thank you for the patch.
I pushed it now so it gets in for the RC2 build that happens tonight.
Comment 3 Mihai Sucan CLA 2011-10-14 05:25:11 EDT 
Thank you for reviewing and landing my patch!