Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360693 - the ToggleLinkingAction just manage link from editor to outline
Summary: the ToggleLinkingAction just manage link from editor to outline
Status: NEW
Alias: None
Product: DLTK
Classification: Technology
Component: Common (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: dltk.common-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-12 12:13 EDT by Simon Bernard CLA
Modified: 2011-10-12 12:13 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Bernard CLA 2011-10-12 12:13:53 EDT 
The ToggleLinkingAction changes the value of  PreferenceConstants.EDITOR_SYNC_OUTLINE_ON_CURSOR_MOVEEDITOR_SYNC_OUTLINE_ON_CURSOR_MOVE.

This preference is only used to activate or deactive the link from editor to outline.
see : org.eclipse.dltk.internal.ui.editor.ScriptEditor.selectionChanged()

The link from outline to editor is always activated.
see : org.eclipse.dltk.internal.ui.editor.ScriptEditor.OutlineSelectionChangedListener

I think this preference should be used for the link in the both side (like JDT).

If you agree with this behaviour, a solution could be to add a check in : org.eclipse.dltk.internal.ui.editor.ScriptEditor.OutlineSelectionChangedListener.selectionChanged(SelectionChangedEvent)