Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360680 - Don't break IDialogConstants API in RAP
Summary: Don't break IDialogConstants API in RAP
Status: NEW
Alias: None
Product: RAP
Classification: RT
Component: JFace (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 major with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-12 11:27 EDT by Tobias Liefke CLA
Modified: 2011-10-12 12:39 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Liefke CLA 2011-10-12 11:27:22 EDT 
I understand that the multi user environment of RAP needs a different localization method than the RCP, but I think that the labels in IDialogConstants should be static (and marked DEPRECATED) for RAP instead of breaking the RCP API.

From my point of view, there are two different use cases for localization in RAP:
1. I write an application that will be localized for every user. Marking the LABEL constants as deprecated would be enough, I can simply find all these deprecated usages and replace them with IDialogLabelKeys like mentioned in 'bug 300472'.
2. I write an application that should display the same language for every user (the "server language), for example because I use a third party library that makes use of the "static" localization like nearly every Eclipse plugin. Now I would have to change that third party library (that maybe isn't available with source code) only to have the dialog buttons localized - but if I go that way further on, I can directly use IDialogLabelKeys, so no use for the non static anymore.

So please make the labels static again and mark them with deprecated (linking to IDialogLabelKeys).