Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360494 - Provide an "Open With" action in the popup menu of file system nodes of Target Explorer.
Summary: Provide an "Open With" action in the popup menu of file system nodes of Targe...
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Target (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.6.0   Edit
Assignee: Project Inbox CLA
QA Contact: Uwe Stieber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-10 23:47 EDT by William Chen CLA
Modified: 2013-06-05 06:01 EDT (History)
4 users (show)

See Also:

Attachments
The patch to fix this bug. (80.96 KB, patch)
2011-10-12 05:43 EDT, William Chen CLA 		uwe.st: iplog+
william.chen: review?
Details | Diff
Updated patch for the previous fix. (3.48 KB, patch)
2011-10-17 02:48 EDT, William Chen CLA 		uwe.st: iplog+
william.chen: review?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description William Chen CLA 2011-10-10 23:47:05 EDT 
Build Identifier: 

Closing the Eclipse editor and double clicking the same file a second time opened the file in the external editor. I didn't found a way to force it back into the Eclipse editor. Please check the behaviour of "Open" and "Open with >" in the context menu of the Package Explorer in example. Basically the same functionality and semantic is expected for the "open/edit remote files" feature.


Reproducible: Always

Steps to Reproduce:
1.Open the file system from Target Explorer view.
2.Right click a file node to show a popup menu.
3.No "Open With" menu is found to select alternative editors.
Comment 1 William Chen CLA 2011-10-11 02:49:38 EDT 
Hi Uwe,

I submitted a bug to add an "Open With" so that it can resolve the issue you reported.

-William
Comment 2 Martin Oberhuber CLA 2011-10-11 04:18:39 EDT 
When you say "Target Explorer" I suppose you want the bug to go into TCF / Target Explorer and not into the RSE bucket. Correct?
Comment 3 William Chen CLA 2011-10-11 04:56:43 EDT 
Yes, yes. Sorry I didn't notice that I had chosen a wrong product and component. Thanks.
Comment 4 William Chen CLA 2011-10-12 05:43:08 EDT 
Created attachment 205010 [details]
The patch to fix this bug.

Hi Uwe,

I created a patch to fix this bug. Please have a review.

Note that in this fix, I also fixed the openChannel problems and made some refactoring.

BTW, there's no binary file added in this patch.

Thanks.

-William
Comment 5 William Chen CLA 2011-10-12 05:43:24 EDT 
I, William Chen, declare that I developed the attached code from scratch,
without referencing any 3rd party materials except materials licensed under the
EPL. I am authorized by my employer to make this contribution under the EPL.

-William Chen
Comment 6 Uwe Stieber CLA 2011-10-14 05:55:45 EDT 
William,
I don't see the "Open With" menu after applying the patch. Under which circumstances is it expected to be shown?
Comment 7 Uwe Stieber CLA 2011-10-14 06:01:11 EDT 
OK. Found it. The "Open With" menu is missing within the target explorer tree if the "Target File System (TCF)" content is enabled (Target Explorer View menu > Customize View... > Content").

Please fix this and submit an updated patch version.
Comment 8 Uwe Stieber CLA 2011-10-14 06:04:28 EDT 
Furthermore, the "open"/double click action does not take the last "open with" selection into account. Check within the package explorer. If switching the editor using "open with", the change is persistent and subsequent double clicking the file opens the editor last set by "open with".
Comment 9 William Chen CLA 2011-10-17 02:48:27 EDT 
Created attachment 205291 [details]
Updated patch for the previous fix.

Yeah, you are right. I forgot to add the menu in the target explorer view.
And in the handler of "Open", which is invoked when double-clicked, did not consider using the persisted default "editor ID". I have fixed both of them in this updated patch. Please apply this patch. 

Thank you very much!
Comment 10 Uwe Stieber CLA 2011-10-18 01:56:15 EDT 
Committed.