Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360421 - [Navigator & Editor Sockets] org.eclipse.sphinx.emf.explorer bug fixes and enhancements
Summary: [Navigator & Editor Sockets] org.eclipse.sphinx.emf.explorer bug fixes and en...
Status: CLOSED FIXED
Alias: None
Product: Sphinx
Classification: Automotive
Component: Core (show other bugs)
Version: 0.7.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.7.0   Edit
Assignee: Stephan Eberle CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-10 06:06 EDT by Lan Phan CLA
Modified: 2021-07-14 02:16 EDT (History)
3 users (show)

See Also:


Attachments
Patch for org.eclipse.sphinx.emf.explorer project (13.63 KB, patch)
2011-10-10 06:16 EDT, Lan Phan CLA
idydieng: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lan Phan CLA 2011-10-10 06:06:49 EDT
Build Identifier: 

Bugs:
1. BasicDropAdapterAssistant#getSelectedEObjects(IStructuredSelection):
...
else if (o instanceof WrapperItemProvider) {
				selectedEObject.add((EObject) ((WrapperItemProvider) o).getValue());
}
...
IWrapperItemProvider.getValue() can be TransientItemProvider object --> ClassCastException

2. CloseResourceOverrideAction: initAction() is declared but not called in constructor


Enhancements:
1. Add javadoc
2. Externalize messages
3. Remove unused attribute 'shellProvider' in CloseResourceOverrideAction
4. IWrapperItemProvider and WrapperItemProvider are used concurrently in BasicDropAdapterAssistant --> modify to use only IWrapperItemProvider

Reproducible: Always
Comment 1 Lan Phan CLA 2011-10-10 06:16:13 EDT
Created attachment 204866 [details]
Patch for org.eclipse.sphinx.emf.explorer project

Proposed patch in attachment
Comment 2 Stephan Eberle CLA 2011-10-17 08:44:04 EDT
Fixed by applying proposed patch. 

Thank you for this valuable contribution!
Comment 3 Balazs Grill CLA 2021-07-14 02:16:46 EDT
Mass-closing Resolved tickets