Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360378 - Confusing behavior when the current file is not part of the refactoring working set
Summary: Confusing behavior when the current file is not part of the refactoring worki...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-refactoring (show other bugs)
Version: 8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 8.0.2   Edit
Assignee: Sergey Prigogin CLA
QA Contact: Emanuel Graf CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-10 00:23 EDT by Sergey Prigogin CLA
Modified: 2011-10-17 23:23 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Prigogin CLA 2011-10-10 00:23:01 EDT 
To reproduce, open rename dialog, enable updates in comments, set refactoring working set to include project A.

Start another rename on a file in project B without opening the refactoring dialog. Change the name of and press Enter. The name reverts back to the original since the file is not included in the refactoring working set. This is confusing to the user.
Comment 1 Sergey Prigogin CLA 2011-10-12 13:25:25 EDT 
Fixed in master. Will submit the fix to cdt_8_0 after more testing in master.
Comment 2 CDT Genie CLA 2011-10-12 14:23:01 EDT 
*** cdt git genie on behalf of Sergey Prigogin ***

    Bug 360378 - Confusing behavior when the current file is not part of the
    refactoring working set. Also show preview whenever there are warnings.

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=58e5dd61e0f9d87379ae7c71d166feb4af4eb010
Comment 3 Sergey Prigogin CLA 2011-10-17 23:21:47 EDT 
Fixed in cdt_8_0 too.
Comment 4 CDT Genie CLA 2011-10-17 23:23:04 EDT 
*** cdt git genie on behalf of Sergey Prigogin ***

    Bug 360378 - Confusing behavior when the current file is not part of the
    refactoring working set. Also show preview whenever there are warnings.

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=806b1a45b06796893f51157b705a94ff84e2fb90