Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360361 - refreshing repository configuration does not reflect added products
Summary: refreshing repository configuration does not reflect added products
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.7   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-09 10:42 EDT by Steffen Pingel CLA
Modified: 2011-10-15 09:56 EDT (History)
1 user (show)

See Also:

Attachments
mylyn/context/zip (28.70 KB, application/octet-stream)
2011-10-14 15:55 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2011-10-09 10:42:21 EDT 
Steps:
1. Open search page
2. Add product in Bugzilla
3. Refresh

The new product is not displayed.
Comment 1 Steffen Pingel CLA 2011-10-14 15:55:11 EDT 
Frank, looking at BugzillaSearchPage.updateAttributesFromConfiguration() the update of products is guarded by a check for "if (selectedProducts == null)". This will cause the product refresh to be skipped if a product was already selected. Do you know the reason for that check?
Comment 2 Steffen Pingel CLA 2011-10-14 15:55:39 EDT 
Created attachment 205233 [details]
mylyn/context/zip
Comment 3 Steffen Pingel CLA 2011-10-14 16:44:13 EDT 
I think I figured out the reason but I noticed some inconsistencies in the handling of the product selection. I have refactored the code and fixed it in 39b557b0fea24a89310d2493e44dc00b1a30c8c1
Comment 4 Steffen Pingel CLA 2011-10-15 08:55:07 EDT 
The change caused a regression when no product is selected.
Comment 5 Steffen Pingel CLA 2011-10-15 09:56:44 EDT 
Committed a follow-up fix to handle the case of an empty product selection.