Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360352 - [Legacy] CDODeltaNotification.getNewValue() returns a CDOLegacyWrapper instead of the wrapped EObject
Summary: [Legacy] CDODeltaNotification.getNewValue() returns a CDOLegacyWrapper instea...
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.legacy (show other bugs)
Version: 4.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Martin Fluegge CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-09 07:21 EDT by Martin Fluegge CLA
Modified: 2012-09-21 06:51 EDT (History)
2 users (show)

See Also:
stepper: review+

Attachments
Patch v1 (combined) (10.26 KB, patch)
2011-10-09 08:33 EDT, Martin Fluegge CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Fluegge CLA 2011-10-09 07:21:31 EDT 
Cloned from: 359992: [Legacy] CDODeltaNotification.getNewValue() returns a CDOLegacyWrapper instead of the wrapped EObject
https://bugs.eclipse.org/bugs/show_bug.cgi?id=359992

Build Identifier: CDO Model Repository SDK	4.0.0.v20110831-1303	org.eclipse.emf.cdo.sdk.feature.group

In legacy mode, with CDOTransaction.options().addChangeSubscriptionPolicy(CDOAdapterPolicy.ALL) set, on commit of a new legacy object added, the remote clients receives a CDODeltaNotification with newValue instanceof CDOLegacyWrapper

Reproducible: Always

This is the 4.0 version of the bug fixed on HEAD (4.1)
Comment 1 Martin Fluegge CLA 2011-10-09 08:33:18 EDT 
Created attachment 204833 [details]
Patch v1 (combined)

I adapted the patch to 4.0.
Comment 2 Eike Stepper CLA 2011-10-10 02:26:13 EDT 
Hi Martin, when you clone bugs, please ensure that the assignee is initially not set. Only then it goes through the inbox and other users have the chance to cc themselves by watching the inbox user ;-)
Comment 3 Eike Stepper CLA 2011-10-10 02:27:33 EDT 
Strange, the patch is full of conflicts if applied against 4.0.
Comment 4 Martin Fluegge CLA 2011-10-10 03:04:54 EDT 
> Strange, the patch is full of conflicts if applied against 4.0.

Hmm, strange. I'll check this when I am at home.
Comment 5 Martin Fluegge CLA 2011-10-10 13:04:18 EDT 
Eike,

I had no problem applying the patch against the 4.0 branch. Only if I try to apply it against HEAD it produces conflicts. Did you choose the wrong branch by accident?

Could you please re-check?
Comment 6 Eike Stepper CLA 2011-10-10 13:24:59 EDT 
My workspace was not in sync ;-(
Comment 7 Martin Fluegge CLA 2011-10-10 13:41:22 EDT 
Committed revision 9471
Comment 8 Eike Stepper CLA 2012-09-21 06:51:10 EDT 
Closing.