Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360270 - HTML representation of a folder not displaying last modified correctly
Summary: HTML representation of a folder not displaying last modified correctly
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Server (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 trivial (vote)
Target Milestone: 2.0 M1   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2011-10-07 14:58 EDT by John Arthorne CLA
Modified: 2012-11-16 14:22 EST (History)
1 user (show)

See Also:
john.arthorne: review+

Attachments
Screen shot (7.22 KB, image/png)
2011-10-07 14:58 EDT, John Arthorne CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2011-10-07 14:58:12 EDT 
Our HTML representation of folders can be seen by navigating straight to a folder, such as:

http://orion.eclipse.org/file/f?depth=1

This is currently displaying last modified time in milliseconds since the epoch - not very user friendly.
Comment 1 John Arthorne CLA 2011-10-07 14:58:22 EDT 
Created attachment 204772 [details]
Screen shot
Comment 2 Jaxsun McCarthy Huggan CLA 2012-11-14 01:28:45 EST 
Request for review, Formats the last modified date in a human readable format
repo URL: https://github.com/Jaxsun/orion.server
branch name: 360270_FormattedLastModified
commit ID: b33e5c2c72cd7da524b1fbe640ae5377ea418e58
Comment 3 John Arthorne CLA 2012-11-14 09:16:45 EST 
Thanks for the contribution! I can review this. It should be java.util.Date instead of java.sql.Date.
Comment 4 John Arthorne CLA 2012-11-14 09:19:07 EST 
Can you please confirm in this bug report that you wrote this code yourself, and that you have the right to contribute your change to Eclipse? This is just part of our legal tracking that you have given us the right to pull in that change from your git clone.
Comment 5 John Arthorne CLA 2012-11-15 12:25:36 EST 
Jaxsun please see question in previous comment.
Comment 6 Jaxsun McCarthy Huggan CLA 2012-11-16 05:21:27 EST 
Corrected Date import

I confirm that I authored this code myself and I have the right to contribute to Eclipse. This change may be pulled into Eclipse Orion.

new patch information

repo URL: https://github.com/Jaxsun/orion.server
branch name: 360270_FormattedLastModified
commit ID: 4f7649ec176ac6afbaf44d834c2c114a8ee44d48

Thank you John.
Comment 7 John Arthorne CLA 2012-11-16 14:22:19 EST 
Fix pushed:

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=b66cab7c7d62981b3ed30a62237bef6e7c3e29d7

Thanks again for your contribution. Welcome to the group of people who helped write Orion!