Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360240 - Jetty prints unwanted messages to System.out
Summary: Jetty prints unwanted messages to System.out
Status: CLOSED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: server (show other bugs)
Version: 8.0.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Greg Wilkins CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-07 10:22 EDT by Rüdiger Herrmann CLA
Modified: 2011-10-11 07:17 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rüdiger Herrmann CLA 2011-10-07 10:22:51 EDT
When an (application) exception occurs, Jetty prints the exception stack trace and floods the console with handle/unhandle messages :
handle {}
unhandle {}
handle {}
unhandle {}
...
Comment 1 Rüdiger Herrmann CLA 2011-10-07 10:24:14 EDT
I am using Jetty 8.0.2.SNAPSHOT from 2011-10-04
Comment 2 Joakim Erdfelt CLA 2011-10-07 14:13:47 EDT
What logging framework are you using?

Internal StdErrLog
Slf4J?
Java.util.logging?
Comment 3 Rüdiger Herrmann CLA 2011-10-08 07:49:25 EDT
(In reply to comment #2)
> What logging framework are you using?
> [ ... ]
I use a custom implementation of org.eclipse.jetty.util.log.Logger. 
I found out that it is a debug message that is passed to the logger which then prints to System.out. Is it inteded that code from AsyncHttpConnection actively enables debug messages (method handle, line 141)?
Comment 4 Greg Wilkins CLA 2011-10-09 23:18:13 EDT
The NO_PROGRESS detection was intended to enable debugging.  But we believe that we have now found the cause of that NO_PROGESS problem so the handling no longer enables debugging on NO PROGRESS.

However it will still log a warning and a dump - which if you see, you should raise and issue.

Also the the "handle {}" should have been expanded, but is obviously not being done by you custom org.eclipse.jetty.util.log.Logger.  You may want to borrow the code from     StdErrLog#format(StringBuilder builder, String msg, Object... args) to expand the {} in the strings.

Can you confirm that you are not seeing such debug in the 8.0.2 release?
Comment 5 Rüdiger Herrmann CLA 2011-10-10 04:40:19 EDT
Thanks for your thorough explanation
(In reply to comment #4)
> The NO_PROGRESS detection was intended to enable debugging.  But we believe that
> we have now found the cause of that NO_PROGESS problem so the handling no longer
> enables debugging on NO PROGRESS.
> 
> However it will still log a warning and a dump - which if you see, you should
> raise and issue.
I will do if I see such a warning

> Also the the "handle {}" should have been expanded, but is obviously not being
> done by you custom org.eclipse.jetty.util.log.Logger.  You may want to borrow
> the code from     StdErrLog#format(StringBuilder builder, String msg, Object...
> args) to expand the {} in the strings.
Yes, the {} are caused by my poor logger implementation

> Can you confirm that you are not seeing such debug in the 8.0.2 release?
The http://download.eclipse.org/jetty/updates/jetty-bundles-8.x repo still shows 8.0.1
Where can I find a p2 repo/bundles of the 8.0.2 release?
Comment 6 Jan Bartel CLA 2011-10-10 22:57:12 EDT
Rüdiger,

The 8.0.2 bundles were there, just not listed on the index page. They are now:

http://download.eclipse.org/jetty/updates/jetty-bundles-8.x/

cheers
Jan
Comment 7 Rüdiger Herrmann CLA 2011-10-11 04:09:34 EDT
(In reply to comment #6)
> The 8.0.2 bundles were there, just not listed on the index page. They are now:
> http://download.eclipse.org/jetty/updates/jetty-bundles-8.x/
> 
> Jan
Thanks Jan, from my POV the issue can be closed. I would reopen if the warning reappears.
Comment 8 Jan Bartel CLA 2011-10-11 07:17:05 EDT
Fixed for 8.0.2