Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360204 - Make RWTServletContextListener and RWTDelegate API
Summary: Make RWTServletContextListener and RWTDelegate API
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.5 M3   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-07 04:37 EDT by Rüdiger Herrmann CLA
Modified: 2011-10-21 11:20 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rüdiger Herrmann CLA 2011-10-07 04:37:47 EDT 
A common way to work with RWT standalone is to declare the RWTDelegate and RWTServletContextListener in the web.xml. (e.g. as desribed in the FAQ http://wiki.eclipse.org/RAP/FAQ#How_do_I_use_an_RWT_standalone_application_in_Tomcat). Both classes are in packages marked internal. But as they are necessary to run RWT they should become part of the public API. 

I propose to create a package org.eclipse.rwt.engine (or use the existing ...application package?) and move both classes there. To preserve backwards-compaibility we could also put classes that derive from the respective class into the public package.
Comment 1 Frank Appel CLA 2011-10-07 04:57:50 EDT 
In this context we could probably change the name of RWTDelegate to somewhat more conclusive...
Comment 2 Ralf Sternberg CLA 2011-10-08 11:44:28 EDT 
How about RWTServlet? This seems to be the obvious name.
Comment 3 Frank Appel CLA 2011-10-08 14:48:47 EDT 
(In reply to comment #2)
> How about RWTServlet? This seems to be the obvious name.
+1
Comment 4 Rüdiger Herrmann CLA 2011-10-13 17:32:56 EDT 
I introduced an 'org.eclipse.rwt.engine' package and put
* RWTServlet (extends RWTDelegate) and 
* RWTServletContextListener (extends internal RWTServletContextListener)
there.
Please re-open if you disagree or if you can suggest a better name for RWTServletContextListener
Comment 5 Frank Appel CLA 2011-10-14 02:19:51 EDT 
I think we should remove Application#createServlet() and use the new RWTServlet directly before we resolve this bug.
Comment 6 Ralf Sternberg CLA 2011-10-14 06:06:53 EDT 
(In reply to comment #5)
> I think we should remove Application#createServlet() and use the new RWTServlet
> directly before we resolve this bug.
+1
Comment 7 Rüdiger Herrmann CLA 2011-10-14 08:33:47 EDT 
(In reply to comment #5)
> I think we should remove Application#createServlet() and use the new RWTServlet
> directly before we resolve this bug.
Of course. Changes are in CVS HEAD
Comment 8 Rüdiger Herrmann CLA 2011-10-21 11:20:36 EDT 
Even though this is a breaking change, we finally decided to move RWTDelegate and RWTServletContextListener to the API package o.e.rwt.engine.
Changes are in CVS HEAD