Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 360076 - IApplicationStore should align with ISessionStore
Summary: IApplicationStore should align with ISessionStore
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.5   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.5 M3   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-06 05:48 EDT by Rüdiger Herrmann CLA
Modified: 2011-10-17 07:00 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rüdiger Herrmann CLA 2011-10-06 05:48:49 EDT 
ISessionStore does not allow null-values in its setAttribute() and removeAttribute() methods. ApplicationStoreImpl currently does not check for null-values.
I suggest to check for null-values in ApplicationStoreImpl to align its behavior with the session store
Comment 1 Rüdiger Herrmann CLA 2011-10-07 06:05:24 EDT 
If this was implemented as suggested, the null-checks in ApplicationConfigurationImpl#setAttribute() would becoome obsolete.
Comment 2 Ralf Sternberg CLA 2011-10-08 09:51:20 EDT 
+1 for disallowing null values
Comment 3 Rüdiger Herrmann CLA 2011-10-17 07:00:46 EDT 
Implemented as suggested. Changes are in CVS HEAD.