Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359988 - expand/collapse icons not displaying in editor
Summary: expand/collapse icons not displaying in editor
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.3 RC1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-05 09:58 EDT by Mark Macdonald CLA
Modified: 2011-10-11 15:40 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2011-10-05 09:58:26 EDT 
Orion 10/5 HEAD

1. Open a .js file that has some /** */ comment blocks
2. The collapse icon should be visible beside the /** delimiter but it is not.
Comment 1 Mark Macdonald CLA 2011-10-05 10:12:14 EDT 
As part of the relative-URL work, the expand/collapse icons were changed from <img src=".."> to <img class=".."> with a background-image set by CSS. The problem here seems to be that background-image does not set the <img> element's height & width.
Comment 2 Mark Macdonald CLA 2011-10-05 10:29:17 EDT 
(In reply to comment #1)
> The problem here seems to be that background-image does not set the <img> 
> element's height & width.

This can be fixed in CSS by setting height & width explicitly (and display:block since apparently inline elements do not support this). The image then appears.

Unfortunately I also get a grey line around the image in WebKit and IE.
Comment 3 Mark Macdonald CLA 2011-10-05 11:34:06 EDT 
(In reply to comment #2)
> Unfortunately I also get a grey line around the image in WebKit and IE.
Turns out this is the edge of the "broken image" icon that appears because "src" is not set on <img>. Changing to <div> avoids this.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=25c81032eb75cda19474d8e40d021f13186c888a