Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359935 - Links generated by search are broken
Summary: Links generated by search are broken
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.3   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 0.3 RC1   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-04 20:43 EDT by Mark Macdonald CLA
Modified: 2011-10-04 23:21 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2011-10-04 20:43:22 EDT 
Orion 0.3 10/04

1. Log in to Orion
2. Press the 't' key to open the "Find File Named" dialog
3. Type in a query that returns some results
4. Try to open one of the results. The URL is invalid and doesn't load.

The URL looks like:
http://localhost:8080../edit/edit.html#/file/a/bundles/org.eclipse.orion.client.core/web/orion/searchClient.js

Same problem applies to the results returned by a global search from the Orion toolbar.
Comment 1 libing wang CLA 2011-10-04 21:41:04 EDT 
(In reply to comment #0)

> The URL looks like:
> http://localhost:8080../edit/edit.html#/file/a/bundles/org.eclipse.orion.client.core/web/orion/searchClient.js

searchClient.js used  [hostname + "edit/edit.html"] before(line 169, 228), after changing it to  hostname + require.toUrl("edit/edit.html") , it no longer works.
I removed hostname part , seems working now.
Comment 2 libing wang CLA 2011-10-04 21:46:13 EDT 
fixed wit h69b421e352c65acf82659c9757f9c61a26151651
Comment 3 Simon Kaegi CLA 2011-10-04 23:21:51 EDT 
Good Catch. I've updated many urls over the last couple of days and fully missed the hostname on this one. Thanks Libing.