Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359876 - Debug icon only appears in first VE preview tab
Summary: Debug icon only appears in first VE preview tab
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Justin Spadea CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-04 12:57 EDT by Justin Spadea CLA
Modified: 2017-02-23 14:20 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Spadea CLA 2011-10-04 12:57:38 EDT 
The contributions for the preview's toolbar incorrectly implemented. It turns out that there is only one instance of the action contribution, so when telling it to fill into the preview's toolbar it only does so if it's not already in a toolbar.

Ideally all the buttons in the preview and design toolbars would be singleton (for the hard-coded buttons each editor currently creates a new instance). We will make that a separate work item for 1.0. For 0.7.0 we should have a singleton "contribution toolbar" that gets inserted next to the hard-coded preview toolbar items. This way contributed actions will show up for every editor.
Comment 1 Justin Spadea CLA 2011-10-05 14:12:23 EDT 
After discussing this a bit, we decided to remove the icon from the toolbar. It's redundant, the common debug icon in the main workbench toolbar does exactly the same thing.

Since the contribution code only works for the first open editor, it has been removed from EvPreviewToolbar.java. We can make it extensible in a future release.
Comment 2 Justin Spadea CLA 2011-10-31 15:48:16 EDT 
Verified