This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 359863 - Support for complex annotation attributes
Summary: Support for complex annotation attributes
Status: CLOSED FIXED
Alias: None
Product: Tigerstripe (Archived)
Classification: Technology
Component: Annotations (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 enhancement (vote)
Target Milestone: 0.5M0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 320068 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-10-04 12:05 EDT by Navid Mehregani CLA
Modified: 2012-03-01 16:00 EST (History)
3 users (show)

See Also:

Attachments
Detailed analysis (56.06 KB, application/octet-stream)
2011-10-04 12:10 EDT, Navid Mehregani CLA 		no flags Details
First pass on annotations' reference attributes. (205.28 KB, patch)
2011-10-24 20:01 EDT, Semyon Koptelov CLA 		no flags Details | Diff
Second pass on implementing this feature. (197.97 KB, patch)
2011-10-27 18:13 EDT, Semyon Koptelov CLA 		no flags Details | Diff
Second pass on implementing this feature. (196.10 KB, patch)
2011-10-27 18:42 EDT, Semyon Koptelov CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Navid Mehregani CLA 2011-10-04 12:05:04 EDT 
Build Identifier: 

Certain annotation attributes need to reference other model components.  At the moment this is done by referencing the FQN/name of the model component as an EString type.  This is error prone and time consuming.  This enhancement will provide the ability to select specific model components in the UI.

Please see attached document for more details.

Reproducible: Always
Comment 1 Navid Mehregani CLA 2011-10-04 12:10:29 EDT 
Created attachment 204522 [details]
Detailed analysis
Comment 2 Semyon Koptelov CLA 2011-10-24 20:01:47 EDT 
Created attachment 205872 [details]
First pass on annotations' reference attributes.

Supports backwards-compatible GUI over strings as well as new ModelReference model object. GUI customizations should be done by configuring/overriding ModelReferenceCellEditor. See o.e.t.annotation.example plugin for examples.

Does not support lists yet.


Use these options to apply the patch:
* Apply the patch to the workspace root
* Ignore leading path name segments = 2
Comment 3 Semyon Koptelov CLA 2011-10-27 18:13:43 EDT 
Created attachment 206100 [details]
Second pass on implementing this feature.

Supports lists.

Use these options to apply the patch:
* Apply the patch to the workspace root
* Ignore leading path name segments = 2
Comment 4 Semyon Koptelov CLA 2011-10-27 18:42:19 EDT 
Created attachment 206102 [details]
Second pass on implementing this feature.

Second pass on implementing this feature. (removed irrelevant patch section)

Supports lists.

Use these options to apply the patch:
* Apply the patch to the workspace root
* Ignore leading path name segments = 2
Comment 5 Anton Salnik CLA 2011-10-31 07:17:52 EDT 
http://wiki.eclipse.org/IModelComponent_References_in_Annotation_Attributes wiki page added.
Comment 6 Navid Mehregani CLA 2011-10-31 12:06:20 EDT 
Code review was completed by Richard and myself on Oct 31 2011.
Comment 7 Anton Salnik CLA 2011-11-01 07:30:05 EDT 
Patch applied.
Comment 8 Navid Mehregani CLA 2011-11-03 11:14:20 EDT 
Verified. Thanks!
Comment 9 Navid Mehregani CLA 2012-03-01 16:00:33 EST 
*** Bug 320068 has been marked as a duplicate of this bug. ***