Community
Participate
Working Groups
Build Identifier: If the chosen workspace is locked Eclipse will not be able to use it and show an error dialog (see attachment). This dialog does report the workspace to be in use, but it does not list the workspace location. Some users start their Eclipse with preconfigured workspaces, these users in particular would benefit from this dialog stating the workspace location again, which seems like a small and risk-free change with some value to it !:) Let me know what you think Reproducible: Always Steps to Reproduce: 1. Start Eclipse with Workspace "C:\data" 2. Start another Eclipse with the same Workspace 3. see error for the second Eclipse instance does not contain the ws location
Created attachment 204510 [details] Error dialog describing the problem: WS is in use.
CQ:WIND00188567 Setting Eclipse version to 3.7, adding attachment.
Makes sense to me. Helmut, would you be able to contribute a patch for this?
Created attachment 207525 [details] proposed patch to address this issue Here is a proposed patch, it's my first using git so let me know if I did this right, here is my workflow: 1.) clone git repo (git://git.eclipse.org/gitroot/platform/eclipse.platform.ui.git/) 1.1) I only cloned the master branch, hope that's right 2.) Create a fix, it's merely an NLS change adding the workspace location to the message text 3.) Check in the fix to my local clone 4.) Use e-git to create a patch from the commit Let me know what you think... Helmut
Hi Helmut, Thanks for the patch, your Git workflow is what we use too ( http://wiki.eclipse.org/EGit/User_Guide#Creating_Patches ), I guess it is as good as it gets. For the patch, there are two error messages - one used on restart (that's the one you updated) and one used in initial startup. From the description, it seemed that you were more interested in the startup case, so I updated that one as well. Changes released in Git 3.8: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R3_development&id=52ed8db064ace7c83cff1ad6f046f3fba1f2fc03 and 4.2: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b7d1f7d2265b33124651890f1c3edf71e5b5280d Thanks for the patch!
(In reply to comment #5) > Hi Helmut, > Thanks for the patch, your Git workflow is what we use too ( > http://wiki.eclipse.org/EGit/User_Guide#Creating_Patches ), I guess it is as > good as it gets. > > For the patch, there are two error messages - one used on restart (that's the > one you updated) and one used in initial startup. From the description, it > seemed that you were more interested in the startup case, so I updated that one > as well. > > Changes released in Git 3.8: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R3_development&id=52ed8db064ace7c83cff1ad6f046f3fba1f2fc03 > > and 4.2: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b7d1f7d2265b33124651890f1c3edf71e5b5280d > > Thanks for the patch! Thank you Remy for going through the effort with me! :) Helmut
> Thank you Remy for going through the effort with me! :) > Helmut Oleg and Remy that should have been, sorry ... Helmut
