Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359834 - [Commands] Toolbars should be SWT.FLAT
Summary: [Commands] Toolbars should be SWT.FLAT
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-04 09:38 EDT by Carsten Pfeiffer CLA
Modified: 2019-11-14 03:21 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carsten Pfeiffer CLA 2011-10-04 09:38:26 EDT
Build Identifier: I20110916-1615

We have some toolbars which looked fine with Eclipse 3.x, but which are rendered in a 3D look in e4.

In 3.x, DefaultActionBarPresentationFactory made sure that all toolbars are flat. In e4, there is no factory anymore. E.g. EditorActionBars.getToolBarManager() explicitly creates ToolBarManager2 instances without specifying the appropriate style flags.

I'm not sure in which scenarios this happens because I do not know that code, but it happens for editors with a custom IEditorActionBarContributor set for us.

Reproducible: Always
Comment 1 Eric Moffatt CLA 2011-10-07 15:09:25 EDT
Paul , any idea where we need to hook into the ToolbarManager in order to define its default flags ?
Comment 2 Paul Webster CLA 2011-10-19 19:13:53 EDT
Eric, these used to come from Presentation factories in 3.x.  We don't have a mechanism to provide a style to the renderer for the e4 part.

PW
Comment 3 Lars Vogel CLA 2019-11-14 03:21:12 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.