Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359775 - EGL Data view's insert data wizards needs to clean up the dataType list
Summary: EGL Data view's insert data wizards needs to clean up the dataType list
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Huo Zhen Zhong CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-03 17:57 EDT by Jing Qian CLA
Modified: 2017-02-23 14:14 EST (History)
4 users (show)

See Also:


Attachments
fix (2.32 KB, patch)
2011-10-08 03:55 EDT, Huo Zhen Zhong CLA
lasher: iplog+
Details | Diff
new fix (7.54 KB, patch)
2011-10-14 02:00 EDT, Huo Zhen Zhong CLA
lasher: iplog+
Details | Diff
another new fix (2.27 KB, patch)
2011-10-27 07:10 EDT, Huo Zhen Zhong CLA
lasher: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jing Qian CLA 2011-10-03 17:57:53 EDT
From EGL DataView
New => EGL Variable
choose primitive

click data Type drop down, you can see there are still lots of primtives listed, even though some of them aren't supported in EDT 070.

This list needs to be cleaned up to remove the ones we don't support
Comment 1 fahua jin CLA 2011-10-08 03:00:21 EDT
(In reply to comment #0)
> From EGL DataView
> New => EGL Variable
> choose primitive
> 
> click data Type drop down, you can see there are still lots of primtives
> listed, even though some of them aren't supported in EDT 070.
> 
> This list needs to be cleaned up to remove the ones we don't support

Jing,

Thanks for opening the defects for the data view. The test scenario for EGL data view have been created by Pengfei in his complex VE scenario, the ER owner is me. I have not started to test it because lots of other issues with VE before our holiday, and also the MVC blocks some of functions for 'data wizard'.
Comment 2 fahua jin CLA 2011-10-08 03:12:30 EDT
Forest,

I'm consulting to Paul for the accurate supported primitive data types in the EDT. If my current understanding is correct, you should remove following primitive types in EGL variable wizard,

time
bin
num
money


Also, you need to add the number type in the list.
Comment 3 Huo Zhen Zhong CLA 2011-10-08 03:55:45 EDT
Created attachment 204790 [details]
fix
Comment 4 Huo Zhen Zhong CLA 2011-10-08 03:56:37 EDT
fixed to remove time, bin, num, money and add number
Comment 5 Jing Qian CLA 2011-10-08 08:46:37 EDT
I'm not so sure about the Number field, this is a reference filed, kinda like any
so please confirm with Paul/Brian,

At this point, MVC is blocked, since a lot of the validation annotations aren't available yet, so I will leave this bug open till we tested MVC
Comment 6 Paul Harmon CLA 2011-10-10 08:30:31 EDT
I dont see why ANY and NUMBER should not be valid selections. Also, DECIMAL should be allowed to be specified without a length/decimals specified.

It seems that the code provided when the Array is selected is incorrect as well (I am assuming there is a separate defect for this, if not, please update this).

The following types should be listed in the dropdown:

any
boolean
string (but not limited string, so do not allow a length to be specified)
date
timestamp (with and without a pattern)
smallint
int
bigint
decimal (with and without length specified)
float
smallfloat
number
Comment 7 fahua jin CLA 2011-10-12 03:09:36 EDT
According to comments of Paul, I don't think this defect should be marked as resolved. Forest, please update the wizard.
Comment 8 Huo Zhen Zhong CLA 2011-10-13 01:22:51 EDT
Hi, Brian

A field of any type or any array type is filtered out in EGL Data View because there is no widgets match the any type. So I have a question, should we allow user to create a any type in new EGL Variable Wizard? If yes, user will found that the new created any type variable does not shown in the EGL Data View, then he will be confused.
Comment 9 Brian Svihovec CLA 2011-10-13 16:09:52 EDT
I believe the purpose of this wizard is to allow users to define fields that can then be used with the Insert Widget Wizard to create visual elements responsible for displaying or updating the value in those fields.

If the above statement is true, then I think we should not enable users to create variables using Reference types, which means we should remove Any, Number, and Timestamp.  I believe these types should be removed because they require that a value has been assigned to them before they can be used with a widget at runtime, and the current implementation of the wizard does not allow a user to assign an initial value.  We can add this support in the future if necessary, but I am thinking that we will always want to show just value types.

Additional comments:

* The Any type should probably allow the user to choose from a list of All widgets that are available, and it will be up to the user to verify that the right type is being used with the widget at runtime.  This could be something we implement after .7 or after 1.0.

* The Number type should probably allow the user to choose from a list of all widgets that can be used by the value types that can be assigned to a Number (e.g. Decimal, Int, etc), and it will be up to the user to verify that the right type is being used with the widget at runtime.  This could be something we implement after .7 or after 1.0.

* We can leave the TimeStamp type in the wizard if we default a format so that it becomes a Value type (e.g. var1 TimeStamp("YYYYMMDD"); ).  I do not think we should try to add a UI for the ability to specify a format, like we do for precision and length when creating a Decimal.
Comment 10 fahua jin CLA 2011-10-13 20:26:56 EDT
(In reply to comment #9)
> I believe the purpose of this wizard is to allow users to define fields that
> can then be used with the Insert Widget Wizard to create visual elements
> responsible for displaying or updating the value in those fields.
> 
> If the above statement is true, then I think we should not enable users to
> create variables using Reference types, which means we should remove Any,
> Number, and Timestamp.  I believe these types should be removed because they
> require that a value has been assigned to them before they can be used with a
> widget at runtime, and the current implementation of the wizard does not allow
> a user to assign an initial value.  We can add this support in the future if
> necessary, but I am thinking that we will always want to show just value types.
> 
> Additional comments:
> 
> * The Any type should probably allow the user to choose from a list of All
> widgets that are available, and it will be up to the user to verify that the
> right type is being used with the widget at runtime.  This could be something
> we implement after .7 or after 1.0.
> 
> * The Number type should probably allow the user to choose from a list of all
> widgets that can be used by the value types that can be assigned to a Number
> (e.g. Decimal, Int, etc), and it will be up to the user to verify that the
> right type is being used with the widget at runtime.  This could be something
> we implement after .7 or after 1.0.
> 
> * We can leave the TimeStamp type in the wizard if we default a format so that
> it becomes a Value type (e.g. var1 TimeStamp("YYYYMMDD"); ).  I do not think we
> should try to add a UI for the ability to specify a format, like we do for
> precision and length when creating a Decimal.

Forest, would you please open another RFE to record the comments Brian mentioned? Thanks!
Comment 11 Huo Zhen Zhong CLA 2011-10-14 02:00:09 EDT
Created attachment 205169 [details]
new fix
Comment 12 Huo Zhen Zhong CLA 2011-10-14 02:04:05 EDT
Enhancement 360903 is created for support Any and Number types in New Variable Wizard and EGL Data View after 0.7.

Change has made for creating timestamp type variable with default format "YYYYMMDD".
Comment 13 Brian Svihovec CLA 2011-10-14 14:53:45 EDT
Since there is no longer a Time type in EDT, I believe the default format for TimeStamp should be "HHmmss", which represents Time.  The format that I specified earlier would be used for Date, but a Date type already exists.
Comment 14 Huo Zhen Zhong CLA 2011-10-27 07:10:01 EDT
Created attachment 206063 [details]
another new fix
Comment 15 Huo Zhen Zhong CLA 2011-10-27 07:10:57 EDT
change timestamp format to "HHmmss"
Comment 16 Jing Qian CLA 2011-10-27 09:25:28 EDT
I want to point out that our Java and javascript implementation of the default format for timestamp is different.

i.e. if I have 

t timestamp("yyyyMMddHHmmssffffff");
syslib.writeStdOut("current time is: " + t);

in java it prints:       2011-10-26 16:05:15
in javascript it prints: 2011-10-26-16.05.15.000000

I think they both have issues, at the minimal, it should use the same type separator, as far as mili and micro second, I would like to know what should be the expected value for the specific implementation. 

so Forest says to use default as HHmmss
what would the value look like, could you give some example?  (does it use : or . as seperator?)
Comment 17 Jing Qian CLA 2011-10-27 09:25:54 EDT
reopen
Comment 18 Brian Svihovec CLA 2011-10-27 09:29:49 EDT
Jing, 

Please open a new defect for comment 16.  I agree that we need to make sure the runtime implementation of Timestamp is the same between Java and JS, but this defect is to make sure that Insert Data Wizard creates variables correctly.
Comment 19 Huo Zhen Zhong CLA 2011-10-28 02:18:43 EDT
Hi, Jing and Brian
The generated code is "t timestamp("HHmmss");", I have opened defect 362265 for comment 16
Comment 20 Jing Qian CLA 2011-11-11 15:14:36 EST
verified on 2011/11/11/0901's build