Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359762 - [user] do we need util.setUserName
Summary: [user] do we need util.setUserName
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 M2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 359619
Blocks:
  Show dependency tree
 
Reported: 2011-10-03 15:58 EDT by Susan McCourt CLA
Modified: 2012-01-22 01:42 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-10-03 15:58:25 EDT
we have code right now that caches the user name (and I just added code to ensure the LoginDialog keeps it up to date).

But do we really need this utility any more at all?

We were using it to show the user name in places like breadcrumbs, etc.  If we decide we aren't showing the user name in places like that anymore, we should remove the methods and the code that keeps the cache up to date.

I'd like to see the outcome of bug 349531 before we toss this.
Comment 1 Szymon Brandys CLA 2011-10-04 03:57:25 EDT
AFAIK it is not used anymore. User names are displayed by plug-ins. Gosia?
Comment 2 Malgorzata Janczarska CLA 2011-10-04 05:41:08 EDT
First of all I think since we support more than one user service at the time there shouldn't be such a method at all. I can see it is used now only if there's only one user service available, for more than one we wouldn't even know which user name to pass to it.
But I can see that there are still some calls of util.getUserName in navigator. We should first finish discussion on Bug 359619, then go on with removing those util functions.
Comment 3 Susan McCourt CLA 2012-01-22 01:42:15 EST
fixed (nav no longer uses these methods).