Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359702 - [compare] Diff URIs may have parameters and compare container does not respect it
Summary: [compare] Diff URIs may have parameters and compare container does not respec...
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: 0.3 RC1   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-03 08:51 EDT by Szymon Brandys CLA
Modified: 2011-10-03 10:50 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2011-10-03 08:51:31 EDT 
This is the case:
I have my own custom diff URI. It has parameters and looks similar to this /myDiff?beforeStateId=...
The problem is that CompareContainer#resolveDiff from compare-container.js cuts off these parameters what is wrong. The compare container method should not change diff uris and just use them as they are.
Comment 1 Szymon Brandys CLA 2011-10-03 09:10:14 EDT 
We need to get rid of diffURI = params[0]; in compare-container.js line 99.
Comment 2 libing wang CLA 2011-10-03 10:31:53 EDT 
fixed with
Comment 3 libing wang CLA 2011-10-03 10:35:27 EDT 
fixed with 75a35817dc90771cfb34eea9d8785ae765f1e958.
We are using compare.html?conflict#diffURI now. (also tested other options like : compare.html?readonly#diffURI , compare.html?readonly&conflict#diffURI)
Comment 4 Szymon Brandys CLA 2011-10-03 10:50:33 EDT 
Thanks!