Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359694 - JDT Call Chain Completion for Eclipse Recommenders
Summary: JDT Call Chain Completion for Eclipse Recommenders
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Recommenders (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Marcel Bruch CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-03 08:01 EDT by Marko Martin CLA
Modified: 2019-07-24 14:36 EDT (History)
1 user (show)

See Also:

Attachments
Code for feature (174.23 KB, application/x-zip-compressed)
2011-10-03 08:03 EDT, Marko Martin CLA 		no flags Details
Code for feature (171.31 KB, application/x-zip-compressed)
2011-10-13 08:22 EDT, Marko Martin CLA 		no flags Details
Code for feature (171.45 KB, application/x-zip-compressed)
2011-10-13 10:25 EDT, Marko Martin CLA 		marcel.bruch: iplog+
Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marko Martin CLA 2011-10-03 08:01:27 EDT 
Build Identifier: 20100917-0705

JDT Call Chain Completion for Eclipse Recommenders

Reproducible: Always
Comment 1 Marko Martin CLA 2011-10-03 08:03:23 EDT 
Created attachment 204441 [details]
Code for feature

I have the rights to contribute the content.
I am contributing the content under the EPL.
All authors are mentioned in the license headers. These are: Johannes Lerch, Gary Fritz, Marko Martin.
Comment 2 Marcel Bruch CLA 2011-10-05 00:58:05 EDT 
Hi Marko, thanks for your contribution!

I've a comment regarding the license headers:
Could you clearly mark files that are not authored by Johannes with a copyright header that looks like:

>> Copyright (c) 2011 Gary Fritz, Marko Martin.

Since you and Gary own the copyright of the files you created and you are not employed by the university, this must not be the university.

If you added quite some code to an preexisting class written by Johannes, please add your name behind the TU Darmstadt copyright (, and Marko Martin). Otherwise, just adding your name with a short contributor description should be ok.




Regarding the @author tags: Could you please remove them from your class documentation? We only add author  information in the license header in source code but not into the javadoc of the class.

Thanks,
Marcel
Comment 3 Marko Martin CLA 2011-10-13 08:22:50 EDT 
Created attachment 205115 [details]
Code for feature

Here comes the code with refined license headers.
Comment 4 Marko Martin CLA 2011-10-13 10:25:41 EDT 
Created attachment 205131 [details]
Code for feature

Bug fixed which caused reserved variable names to be ignored.
Comment 5 Marcel Bruch CLA 2011-11-29 01:39:20 EST 
Hi Marko, thanks for the contribution. I requested the IP check of you contribution. // sorry for the delay, the notification email slipped through somehow..
Comment 6 Marcel Bruch CLA 2012-01-24 06:53:12 EST 
Marko, it's in :)
Comment 7 Marko Martin CLA 2012-01-24 14:37:30 EST 
(In reply to comment #6)

Good news, thank you :)