Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359687 - Facilitate preview mode
Summary: Facilitate preview mode
Status: CLOSED WONTFIX
Alias: None
Product: Acceleo
Classification: Modeling
Component: Core (show other bugs)
Version: 3.1.1   Edit
Hardware: PC Windows Vista
: P3 enhancement
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-03 06:56 EDT by Ed Willink CLA
Modified: 2015-05-27 08:56 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2011-10-03 06:56:38 EDT 
The auto-generated doGenerate() invokes super.doGenerate() and discards the return value. This requires a user of preview mode to tunnel down to generate().

Suggest, propagate the doGenerate() return.
Comment 1 Laurent Goubet CLA 2011-10-03 08:46:44 EDT 
Ed,

This was designed like that in order to avoid API breakages : "doGenerate()" was initially the only entry point of the generation. However when we added the preview mode, we need a "return" value for the generation ... thus was created "generate()".

Adding a "return" value to doGenerate would not be an API break per se, but it would be a binary compatibility break (granted, I am not sure that we guarantee the binary compatibility of Acceleo ... but at least we avoid obvious breaks).

"doGenerate" will remain as is as long as we do not create an Acceleo 4.0 in which we'll be able to break the API to our heart content, so do not expect to see this solved any time soon :).
Comment 2 Ed Willink CLA 2011-10-03 10:08:35 EDT 
No problem.
Comment 3 Laurent Goubet CLA 2015-05-27 08:56:53 EDT 
Closing resolved bugs