Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359685 - History view should also name branches when filtered by resources
Summary: History view should also name branches when filtered by resources
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.2   Edit
Hardware: PC Windows 7
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-03 06:08 EDT by Markus Keller CLA
Modified: 2012-10-24 08:46 EDT (History)
1 user (show)

See Also:


Attachments
Screenshot (37.56 KB, image/png)
2011-10-03 06:08 EDT, Markus Keller CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-10-03 06:08:12 EDT
Created attachment 204438 [details]
Screenshot

1.2.0.201109290051

The History view list doesn't show the HEAD of my local master branch after I performed "Fetch from Upstream" (but didn't pull yet).

For the screenshot, I selected the state in my working directory. You can see the branches in the comment pane, but not in the list of commits.
Comment 1 Stefan Lay CLA 2012-03-09 04:34:39 EST
I think the reason is that you have selected the filter "Show all changes of selected resource and its children". The selected resource is "ConvertForLoopOperation.java". I guess that this is not changed in the HEAD commit of your local master branch.
Comment 2 Markus Keller CLA 2012-03-09 05:51:18 EST
(In reply to comment #1)
Yes, that explains it. Changing this bug into a request to also show the branch name on the tip if the HEAD commit has been filtered.

The commit list in the screenshot doesn't show the branches, but that would be useful information. The rendering should be different from the normal green background to make it clear that this is not the HEAD on that branch. Maybe gray bg as the origin/master branch?
Comment 3 Stefan Lay CLA 2012-03-09 06:40:46 EST
+1 good idea
Comment 4 Markus Keller CLA 2012-10-24 08:46:56 EDT
> The rendering should be different from the normal
> green background to make it clear that this is not the HEAD on that branch.
> Maybe gray bg as the origin/master branch?

Better use a different color. Gray would be confusing, since the branch doesn't really end on that commit.