359677 – SWT: Plain text in StringField with getConfiguredInputMasked() { return true; }

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359677 - SWT: Plain text in StringField with getConfiguredInputMasked() { return true; }

Summary: SWT: Plain text in StringField with getConfiguredInputMasked() { return true; }

Status:	CLOSED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Scout (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Project Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-10-03 03:31 EDT by Marcel Burkhard
Modified:	2021-08-19 11:12 EDT (History)
CC List:	3 users (show)

See Also:	Git Commit Git Commit

Flags:	stephan.leichtvogt: kepler+

Attachments
Proposal (6.36 KB, application/octet-stream) 2013-02-22 04:36 EST, Rene Eigenheer	stephan.leichtvogt: iplog+	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marcel Burkhard

2011-10-03 03:31:00 EDT

Build Identifier: Eclipse for scout and RAP Developers  Version: Indigo Release Build id: 20110615-0604

See "Steps to reproduce"
It works in swing but not in swt

Reproducible: Always

Steps to Reproduce:
1. Create StringField
2. Set flag "Input Masked"
3. Start SWT
4. Enter text to the string field, text will be shown in plain text instead of *

Comment 1 Rene Eigenheer

2013-02-21 15:45:56 EST

seems to be a consequence as StyledText doesn't support password style. see https://bugs.eclipse.org/bugs/show_bug.cgi?id=149662

Comment 2 Rene Eigenheer

2013-02-22 04:36:04 EST

Created attachment 227444 [details]
Proposal

Proposal for org.eclipse.scout.rt.ui.swt project to enable masked input (Passwords) in SWT.

Comment 3 Judith Gull

2013-03-15 05:54:32 EDT

Thanks for your proposal!
We will analyse it. A patch file would be easier to hanle, even if all lthe classes are new.
Milestone set to M7.

Comment 4 Stephan Leicht Vogt

2013-03-21 11:22:38 EDT

There is many duplicate code now between SwtScoutStringField and SwtScoutStrintPlainTextField. Wouldn't it be possible to create an abstract class which contains the common code and two classes which extend this? 
@René: Could you investigate this and submit a new proposal/patch? Thanks.

Comment 5 Stephan Leicht Vogt

2013-05-07 12:57:49 EDT

I'll push this patch as provided by René so the API Changes are in M7. The duplicate code will be removed for RC1/RC2 from René.

Comment 6 Stephan Leicht Vogt

2013-05-07 14:48:48 EDT

Proposed patch as been pushed as change (https://git.eclipse.org/r/#/c/12592/).

Comment 7 Stephan Leicht Vogt

2013-05-07 15:46:36 EDT

@René: Please could you answer following questions:
 - Did you author 100% of the content you’re contributing?
 - Do you have the rights to contribute this content to Eclipse?
 - Are you willing to contribute the content under the project’s license(s) (e.g. EPL)
 
 As soon as they are answered I allowed to submit your Patch to the Kepler sources (git master).
 --
 Thanks and greetings
 Stephan

Comment 8 Rene Eigenheer

2013-05-08 09:19:15 EDT

yes to all three

cu
Rene

Comment 9 Stephan Leicht Vogt

2013-05-08 09:35:16 EDT

Has been committed to master: 1d83ccb89729307d0a7a4dbc3c8b4485577e2fd6 (http://git.eclipse.org/c/scout/org.eclipse.scout.rt.git/commit/?id=1d83ccb89729307d0a7a4dbc3c8b4485577e2fd6)

Comment 10 Stephan Leicht Vogt

2013-05-08 09:35:31 EDT

@René: As soon as you find some time please consider to go over the issues mentioned in comment #4.

--
Greetings and thank you for the patch
Stephan

Comment 11 Judith Gull

2013-05-14 04:34:58 EDT

 Please also remove the System.out.println in StringFieldFactory.

Comment 12 Ken Lee

2013-05-24 08:33:12 EDT

Removed sysout line with https://git.eclipse.org/r/#/c/13119/. Merged to master with commit ee8d9b748d453d02e87215682ba6b017becd7a42.

Comment 13 Matthias Villiger

2013-06-10 04:03:41 EDT

postponed to 3.9 SR1.

Comment 14 Judith Gull

2013-08-16 12:54:10 EDT

Removed duplicate code with https://git.eclipse.org/r/#/c/15551/

Comment 15 Judith Gull

2013-08-19 04:41:12 EDT

Applied the refactoring only on develop branch. Change cherry-picked as 4ddcf92bc42ae247869d8e44ad6da4f12e8e95d7.

Please verify!

Comment 16 Ken Lee

2013-09-09 09:07:21 EDT

Verified with Eclipse Scout Kepler SR1 RC2 EPP on all front ends.

Comment 17 Matthias Zimmermann

2013-10-15 04:11:53 EDT

Bug closed. Shipped with Kepler SR1

Comment 18 Eclipse Genie

2020-04-01 08:57:32 EDT

Gerrit change https://git.eclipse.org/r/13119 was merged to [master].
Commit: http://git.eclipse.org/c/scout/org.eclipse.scout.rt.git/commit/?id=ee8d9b748d453d02e87215682ba6b017becd7a42

Comment 19 Eclipse Genie

2020-04-01 08:58:08 EDT

Gerrit change https://git.eclipse.org/r/12592 was merged to [master].
Commit: http://git.eclipse.org/c/scout/org.eclipse.scout.rt.git/commit/?id=1d83ccb89729307d0a7a4dbc3c8b4485577e2fd6

Comment 20 Eclipse Genie

2021-02-10 12:25:06 EST

Gerrit change https://git.eclipse.org/r/c/scout/org.eclipse.scout.rt/+/12592 was merged to [master].
Commit: http://git.eclipse.org/c/scout/org.eclipse.scout.rt.git/commit/?id=1d83ccb89729307d0a7a4dbc3c8b4485577e2fd6

Comment 21 Eclipse Genie

2021-02-10 12:25:58 EST

Gerrit change https://git.eclipse.org/r/c/scout/org.eclipse.scout.rt/+/13119 was merged to [master].
Commit: http://git.eclipse.org/c/scout/org.eclipse.scout.rt.git/commit/?id=ee8d9b748d453d02e87215682ba6b017becd7a42