Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359662 - EGit Perspective icon looks out of place
Summary: EGit Perspective icon looks out of place
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.2   Edit
Hardware: PC Windows 7
: P3 trivial (vote)
Target Milestone: 2.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-02 10:20 EDT by Nicolas Bros CLA
Modified: 2013-04-21 18:21 EDT (History)
4 users (show)

See Also:


Attachments
git_perspective.gif (602 bytes, image/gif)
2011-10-02 10:20 EDT, Nicolas Bros CLA
no flags Details
before (1.80 KB, image/png)
2011-10-02 10:21 EDT, Nicolas Bros CLA
no flags Details
after (1.70 KB, image/png)
2011-10-02 10:21 EDT, Nicolas Bros CLA
no flags Details
change 5588/2 with higher color saturation (569 bytes, image/gif)
2012-04-14 19:51 EDT, Matthias Sohn CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2011-10-02 10:20:39 EDT
Created attachment 204425 [details]
git_perspective.gif

When I disable "Show Text" for perspectives and look at icons for the CVS, SVN, and EGit perspectives side by side, the EGit icon looks washed out and is offset by one pixel compared to the other icons.

See the attached screenshot "before".
I propose changing the icon to something more like the attached "gitrepository.gif". Look at the "after" screenshot to see it in context.

I found the icon EGit uses for its perspective icon in:
 org.eclipse.egit.ui/icons/obj16/gitrepository.gif
But this icon might be used in other places in EGit. In this case it should probably be copied to a new icon egit_perspective.gif or something like this.
Comment 1 Nicolas Bros CLA 2011-10-02 10:21:16 EDT
Created attachment 204426 [details]
before
Comment 2 Nicolas Bros CLA 2011-10-02 10:21:27 EDT
Created attachment 204427 [details]
after
Comment 3 Vadim Dmitriev CLA 2011-10-04 07:41:34 EDT
Till that day I thought that funny colors on git perspective icon was due to antialiasing or some subpixel cleartype artifacts :) And only now when closely looking at it I see that these colors where intentional. Maybe it would be better to consistently write VCS name with solid black? It is more readable that way. What do you think?

Regards.
Comment 4 Nicolas Bros CLA 2011-10-04 11:58:33 EDT
(In reply to comment #3)
I thought the color was used to help distinguish the Git perspective. But maybe it is better to have the same color for each of the SCM perspective icons.
Either way suits me.
Comment 5 Matthias Sohn CLA 2012-04-14 19:51:56 EDT
Created attachment 214017 [details]
change 5588/2 with higher color saturation

slight variation of what Robin proposed in https://git.eclipse.org/r/#/c/5588/2 with a higher color saturation in order to increase readability
Comment 6 Tomasz Zarna CLA 2013-04-21 18:21:31 EDT
Fixed in c36a295ac32f9c0b0d1323cffbe4c4619169a541