Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359595 - support filtering of obsolete attachments
Summary: support filtering of obsolete attachments
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 3.7   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2011-09-30 13:58 EDT by Steffen Pingel CLA
Modified: 2011-10-19 08:14 EDT (History)
1 user (show)

See Also:

Attachments
filter (10.46 KB, image/png)
2011-09-30 13:59 EDT, Steffen Pingel CLA 		no flags Details
filter-disabled (1.03 KB, image/png)
2011-10-14 14:22 EDT, Steffen Pingel CLA 		no flags Details
filtered (11.64 KB, image/png)
2011-10-14 14:24 EDT, Steffen Pingel CLA 		no flags Details
screenshot (11.71 KB, image/png)
2011-10-14 18:10 EDT, Steffen Pingel CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2011-09-30 13:58:46 EDT 
The list of attachments can get long, e.g. if multiple iterations of a patch are discussed. The task editor should have a filter to hide deprecated attachments (similar to the Bugzilla web UI).
Comment 1 Steffen Pingel CLA 2011-09-30 13:59:30 EDT 
Created attachment 204404 [details]
filter
Comment 2 Steffen Pingel CLA 2011-10-04 11:32:37 EDT 
A first pass has been committed. The basic functionality is there but we need a better icon. I have put this on the meeting agenda for UI review.
Comment 3 Frank Becker CLA 2011-10-04 15:41:05 EDT 
Steffen,

we have now the problem the it a user select "Open Attachment in Task Editor" of an obsolete attachment we get "Attachment is not attached to the opened bug".

We should 

a) disable this option
b) add the obsolete Tast to the table and select it.
Comment 4 Steffen Pingel CLA 2011-10-04 18:42:17 EDT 
Good point. We should unfilter the table in that case to make the selected attachment visible.
Comment 5 Steffen Pingel CLA 2011-10-13 14:08:28 EDT 
Mik suggested to use a crossed out remove icon.
Comment 6 Steffen Pingel CLA 2011-10-14 14:22:57 EDT 
Created attachment 205229 [details]
filter-disabled
Comment 7 Steffen Pingel CLA 2011-10-14 14:24:21 EDT 
Created attachment 205230 [details]
filtered
Comment 8 Steffen Pingel CLA 2011-10-14 14:26:25 EDT 
I have updated the icon and fixed the issue mentioned in comment #3: the table is now unfiltered if a hidden attachment is clicked.
Comment 9 Steffen Pingel CLA 2011-10-14 18:10:50 EDT 
Created attachment 205239 [details]
screenshot