Description Nigel Westbury 2011-09-30 06:33:44 EDT

Build Identifier: 3.7.0

The code is doing a compare of the String value of the versions.  It should be comparing the Version objects.  The first three components of a version are non-negative integers and must be compared as such.

Our plug-ins have moved on to a minor version of 10 and the target definition is resolving to an older version, causing chaos in our development team.

A patch is attached.  I would have prefered to add getOsgiVersion/setOsgiVersion to BundleInfo and deprecated the getVersion/setVersion methods.  The author of this comparator is PDE probably assumed getVersion was returning the Version object so this change to BundleInfo would help avoid this error.  However that would involve another patch for the Equinox team so may not be worth doing.

I considered catching the IllegalArgumentException and falling back to the string compare, just to make sure that we don't break anyone who might have some invalid version strings out there.  However I think such users would have other problems so giving them an exception is beter.   

Reproducible: Always