Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359494 - Test server not updated when included DD outside EGL path is modified
Summary: Test server not updated when included DD outside EGL path is modified
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Justin Spadea CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-29 17:47 EDT by Justin Spadea CLA
Modified: 2017-02-23 14:18 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Spadea CLA 2011-09-29 17:47:15 EDT
If a DD file is not in the EGL path of the test server it is normally not added to the server's configuration. It can be added though if a DD that's within the EGL path includes it. (It can also be included if it's the default DD for one of the projects on the EGL path, but in that case everything is fine).

The recalculation code is fine, it's just that in this case we haven't determined that we *should* recalculate. Processing all those *.egldd files isn't cheap, so we try to avoid it if the file isn't on the egl path. Since the only way to know that the file is included by a file on the EGL path (or included by a file that is included by a file on the EGL path, etc) would be to parse all those files until we determine yes, this file *is* being used by the server. Given this, it might be that we want to always run the recalculation when a *.egldd file is modified, otherwise we might parse all the files to determine we should recalculate, and then parse them all again to actually gather the information to send to the server.

Whatever we decide on, we'll address it after 0.7.0.
Comment 1 Yun Feng Ma CLA 2011-12-20 03:03:54 EST
Hi Justin,

This sounds like a Debugger test server related issue, do you think CDL should fix it? or you will take care of it? Thanks a lot.
Comment 2 Justin Spadea CLA 2011-12-23 11:40:18 EST
I'll take care of this one since I own the code.
Comment 3 Justin Spadea CLA 2012-02-20 09:46:22 EST
Fixed ServicesContribution.java. We already had a list of the test server's DD files, so instead of checking if the changed file was on the EGL path, we just check if it's part of the known list of DDs.
Comment 4 Justin Spadea CLA 2012-02-22 08:53:41 EST
Closing
Comment 5 Justin Spadea CLA 2012-02-22 10:52:37 EST
Actually closing this time...
Comment 6 Justin Spadea CLA 2012-03-30 15:09:23 EDT
This change needs to be reverted in 0.8.1. We changed the test server to only include DDs in the EGL path, so now the previous check was correct.
Comment 7 Justin Spadea CLA 2012-04-11 08:52:30 EDT
Fix has been reverted.
Comment 8 Justin Spadea CLA 2012-06-22 16:24:50 EDT
Closing