Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359489 - TitleAreaDialog has a gap below the image in Firefox 6
Summary: TitleAreaDialog has a gap below the image in Firefox 6
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 1.5 M3   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-29 17:28 EDT by Arvinder Birdi CLA
Modified: 2011-11-04 11:28 EDT (History)
1 user (show)

See Also:

Attachments
Modified source file in "RAP Application with a view" Template (2.23 KB, text/plain)
2011-10-04 15:59 EDT, Arvinder Birdi CLA 		no flags Details
screen shot of defect (29.72 KB, image/png)
2011-10-04 16:02 EDT, Arvinder Birdi CLA 		no flags Details
Title only, without message: works (29.59 KB, image/png)
2011-10-04 16:07 EDT, Arvinder Birdi CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arvinder Birdi CLA 2011-09-29 17:28:48 EDT 
Build Identifier: Build id: 20110615-0604

Titleareadialog works properly in IE9. 

In Firefox extra white space is put below the image. About 14 pixels in my case. The is clearly visible and causes the lower controls to be hidden in our fixed size dialogs.

Reproducible: Always

Steps to Reproduce:
1. Create a titlarea dialog with an image and 4 entry fields, 2 buttons.
2. Compare rendering in IE9 and firefox.
3.
Comment 1 Ivan Furnadjiev CLA 2011-09-30 02:50:31 EDT 
Could you provide a self running snippet that demonstrate the problem?
Comment 2 Arvinder Birdi CLA 2011-10-04 10:17:36 EDT 
Shell activeShell = PlatformUI.getWorkbench().getDisplay().getActiveShell();

TitleAreaDialog dialog = new TitleAreaDialog(activeShell);
dialog.create();

// Title does NOT affect the problem.
// dialog.setTitle("The Title");

// Setting a message CAUSES the problem.
dialog.setMessage("A message.");
        
dialog.open();

========================================================================
I have tested it on 3 windows 7 (64bit) machines with firefox 7.
It happens on 2 out of 3 of them.
Comment 3 Arvinder Birdi CLA 2011-10-04 15:59:44 EDT 
Created attachment 204548 [details]
Modified source file in "RAP Application with a view" Template

File->defect will launch the TitleAreaDialog with the problem.
Comment 4 Arvinder Birdi CLA 2011-10-04 16:02:25 EDT 
Created attachment 204549 [details]
screen shot of defect
Comment 5 Arvinder Birdi CLA 2011-10-04 16:07:36 EDT 
Created attachment 204550 [details]
Title only, without message: works
Comment 6 Arvinder Birdi CLA 2011-10-04 17:33:05 EDT 
I looked at the outline in the browser debugger. 

It looks like the height of the html textarea used to show the message is too large and extends below the image.
Comment 7 Arvinder Birdi CLA 2011-10-05 13:43:14 EDT 
This works in RCP.
Comment 8 Arvinder Birdi CLA 2011-10-13 17:20:22 EDT 
Problem appears on machines where firefox has gpu acceleration enabled. Use URL "about:support" to check.

Then under Options, Advanced, Browsing:
Unselect "Use hardware acceleration when available" and restart.
This fixes the problem. 

When it is enabled again the problem reappears.
Comment 9 Ivan Furnadjiev CLA 2011-11-04 06:12:31 EDT 
For me it is reproducible in all browsers.
Comment 10 Ivan Furnadjiev CLA 2011-11-04 11:28:41 EDT 
This was a text size determination issue. TitleAreaDialog has a field messageLabelHeight. Based on this field, which was calculated only once ( in TitleAreaDialog#createTitleArea ), the dialog layout is calculated. Fixed by updating the messageLabelHeight and do layoutForNewMessage in the messageLabel resize event. Changes are in CVS HEAD.