Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359477 - Feature Request - CVS component to support Active Directory user name
Summary: Feature Request - CVS component to support Active Directory user name
Status: RESOLVED DUPLICATE of bug 205251
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-29 16:16 EDT by Keerthi Vasan CLA
Modified: 2011-10-11 08:51 EDT (History)
1 user (show)

See Also:

Attachments
ConfigurationWizardMainPage.java (21.76 KB, patch)
2011-09-30 13:00 EDT, Keerthi Vasan CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keerthi Vasan CLA 2011-09-29 16:16:03 EDT 
Build Identifier: Helios Service Release 1 Build id: 20100917-0705 and Helios Service Release 2 Build id: 20110218-0911

We are currently using CVS as our version control system. Also we are using ssh/Active Directory for authenticating the user id and password. The user id we use is something like john.smith@usa.win.int.kn

When I select the CVS repository perspective and select Add New Repository Location and enter the user name as specified above (john.smith@usa.win.int.kn) with an @ symbol - it says Invalid User Name. There is a validateUserName method of ConfigurationWizardMainPage.java called which is checking for @ sign and says it is "Invalid User Name". This java file is under the package org/eclipse/team/internal/ccvs/ui/wizards/. We removed the @ sign check and tested the CVS connection within eclipse - so far it seems to work fine. Would like to if this feature request can be implemented in CVS component of the future releases?



Reproducible: Always

Steps to Reproduce:
1. Open CVS Repository Exploring
2. Add New Repository Location
3. Enter the user name with a @ symbol (for eg. john.smith@usa.win.int.kn
Comment 1 Keerthi Vasan CLA 2011-09-30 13:00:29 EDT 
Created attachment 204399 [details]
ConfigurationWizardMainPage.java

The code has been modified not to check the @ sign for user name:

The following if statment of the validateUserName method has been modified
        if ((user.indexOf('@') != -1) || (user.indexOf(':') != -1)) {
			return new Status(IStatus.ERROR, CVSUIPlugin.ID, INVALID_FIELD_CONTENTS,
					CVSUIMessages.ConfigurationWizardMainPage_invalidUserName, null);
		}


to this (removed the check (user.indexOf('@') != -1) 

	if (user.indexOf(':') != -1) {
			return new Status(IStatus.ERROR, CVSUIPlugin.ID, INVALID_FIELD_CONTENTS,
					CVSUIMessages.ConfigurationWizardMainPage_invalidUserName, null);
		}

Please let us know if this patch can be implemented to the future releases .
Comment 2 Tomasz Zarna CLA 2011-10-11 08:51:39 EDT 
This is not an exact duplicate of bug 205251, but both of them complain about the check for "@" in CVS user name. Fixing one of them will fix both. Magic, could please create a patch from what you suggested in comment 1 and submit it on bug 205251.

*** This bug has been marked as a duplicate of bug 205251 ***