Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359470 - [subclipse] Exception when creating a review item from a new file
Summary: [subclipse] Exception when creating a review item from a new file
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 0.8   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.9   Edit
Assignee: Alvaro Sanchez-Leon CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-29 15:16 EDT by Alvaro Sanchez-Leon CLA
Modified: 2011-09-29 23:43 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alvaro Sanchez-Leon CLA 2011-09-29 15:16:15 EDT 
An exception is triggered when crating review items from new files.

this does not happen when using Git as a vcs, but happes with all other supported connectors
Comment 1 Alvaro Sanchez-Leon CLA 2011-09-29 15:21:33 EDT 
java.lang.NullPointerException
	at org.eclipse.mylyn.internal.subclipse.core.SubclipseConnector.getArtifact(SubclipseConnector.java:96)
	at org.eclipse.mylyn.versions.core.spi.ScmConnector.getArtifact(ScmConnector.java:36)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.utils.CommandUtils.updateBaseFile(CommandUtils.java:253)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.utils.CommandUtils.getBaseFileData(CommandUtils.java:211)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.commands.NewReviewItemHandler.addReviewItemFromText(NewReviewItemHandler.java:184)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.commands.NewReviewItemHandler.access$0(NewReviewItemHandler.java:179)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.commands.NewReviewItemHandler$1.runInUIThread(NewReviewItemHandler.java:107)
	at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4140)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3757)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
Comment 2 Alvaro Sanchez-Leon CLA 2011-09-29 23:43:14 EDT 
A validation of resolution of artifact was missing.
It's now fixed.
Comment 3 Alvaro Sanchez-Leon CLA 2011-09-29 23:43:59 EDT 
see comment above