Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359469 - [subclipse] Adding a resource review item using SVN displays version 5
Summary: [subclipse] Adding a resource review item using SVN displays version 5
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 0.8   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.0   Edit
Assignee: Sebastien Dubois CLA
QA Contact:
URL:
Whiteboard:
Keywords: plan
Depends on:
Blocks: 375372
  Show dependency tree
 
Reported: 2011-09-29 15:10 EDT by Alvaro Sanchez-Leon CLA
Modified: 2012-05-24 14:04 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alvaro Sanchez-Leon CLA 2011-09-29 15:10:33 EDT 
Adding a review item i.e. manual selection of line range on a resource.
is created  with revision 5.
Comment 1 Alvaro Sanchez-Leon CLA 2012-02-23 07:28:09 EST 
SVNRevision give us access to the "kind" which is set to 5 to indicate Base file (for the case when we create a remote svn file instance from an IFile).
However this does not give the actual revision number.
  
 Some test have to be done to identify the best way to resolve to the remote base revision number.
 we could start e.g.
			ISVNLocalFile svnFile = SVNWorkspaceRoot.getSVNFileFor((IFile) resource);
			svnFile.getUrl();
Comment 2 Steffen Pingel CLA 2012-05-23 17:41:15 EDT 
Alvaro, are you planning to resolve this for 1.0?
Comment 3 Alvaro Sanchez-Leon CLA 2012-05-23 21:58:39 EDT 
(In reply to comment #2)
> Alvaro, are you planning to resolve this for 1.0?

This one is fixed by Sebastien's commit for:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=375372

Sebastien, could you please mark this one as fixed ?
Comment 4 Sebastien Dubois CLA 2012-05-24 14:04:43 EDT 
Solved with solution for bug375372