Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359430 - Generating just sql-script has unnecessary warning dialog
Summary: Generating just sql-script has unnecessary warning dialog
Status: RESOLVED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: JPA (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1   Edit
Assignee: Tran Le CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-29 10:15 EDT by Karen Butzke CLA
Modified: 2011-10-25 20:02 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karen Butzke CLA 2011-09-29 10:15:44 EDT 
Choose to generate tables for a JPA project and choose 'Sql-script' as the Generation Output Mode. When you click finish a dialog appears warning you that "Generating DLL will DROP existing tables...". This dialog should not appear for just generating the sql-script. The dialog also needs to be changed to reflect that the sql-script will be run and that is what will drop and create new tables.
Comment 1 Neil Hauge CLA 2011-10-18 16:27:55 EDT 
(In reply to comment #0)
> The dialog also needs to be changed to
> reflect that the sql-script will be run and that is what will drop and create
> new tables.

Do you have a specific suggestion for this?  Not sure if I see the point of making this distinction, but perhaps an example would clear things up for me.
Comment 2 Karen Butzke CLA 2011-10-19 07:05:10 EDT 
I'm not sure what I was saying, I must have confused a word or two! If you choose 'sql-script' there should be no warning dialog. If you choose 'Database' or 'Both' we do need a warning dialog. I think I was trying to say that the warning should say something other than 'Generating DDL...'. Maybe 'Generating tables...' at that point would make more sense.
Comment 3 Neil Hauge CLA 2011-10-19 08:09:16 EDT 
Ok.  That sounds reasonable to me.
Comment 4 Tran Le CLA 2011-10-25 20:02:04 EDT 
Fixed in M3