Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359418 - Bookmark Management Customization
Summary: Bookmark Management Customization
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Scout (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-29 09:09 EDT by Adrian Moser CLA
Modified: 2021-08-19 11:03 EDT (History)
2 users (show)

See Also:
zimmermann: indigo+
zimmermann: juno+

Attachments
Proposed Patch (25.17 KB, patch)
2011-09-29 09:10 EDT, Adrian Moser CLA 		andi.bur: iplog+
Details | Diff
Patch for additional improvments. (11.39 KB, patch)
2011-10-05 04:22 EDT, Adrian Moser CLA 		andi.bur: iplog+
Details | Diff
Enhancements/fixes for the bookmark field. (14.85 KB, patch)
2011-10-13 05:04 EDT, Adrian Moser CLA 		andi.bur: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Moser CLA 2011-09-29 09:09:36 EDT 
Build Identifier: M20110210-1200

Changes/Fixes to Scout Bookmark Handling:
- Scout implementation should be able to use a customized BookmarkForm
- AbstractBookmarkTreeField: New/Edit Menu PrepareActions (Permissions) should be customizable
- AbstractBookmarkTreeField : "New Folder" should not be possible on Bookmark Node
- Text for Global/Private Bookmarks should be configurable

Reproducible: Always
Comment 1 Adrian Moser CLA 2011-09-29 09:10:09 EDT 
Created attachment 204288 [details]
Proposed Patch
Comment 2 Andi Bur CLA 2011-09-30 03:26:07 EDT 
Comment on attachment 204288 [details]
Proposed Patch

applied a slightly modified version of the patch:
o replaced AbstractBookmarkForm extends AbstractForm by IBookmarkForm implements IForm (because it contains only methods)
o replaced exception handling using IExceptionHandlerService by LOG.warn
Comment 3 Adrian Moser CLA 2011-10-05 04:21:47 EDT 
Additional required improvments:
- Private Folder should be removed (not needed)
- Support for additional logic when user opens bookmark: IOpenBookmarkCommand
- AbstractBookmarkTreeField: Support for custom icons
- BookmarkFolderForm: Grid width should be 1.
- IBookmarkForm: JavaDoc shoud be added.
- Bookmark: Support for new Bookmark (unread Bookmarks) should be added
Comment 4 Adrian Moser CLA 2011-10-05 04:22:35 EDT 
Created attachment 204572 [details]
Patch for additional improvments.

Patch for additional improvments.
Comment 5 Andi Bur CLA 2011-10-05 04:53:18 EDT 
Comment on attachment 204572 [details]
Patch for additional improvments.

applied patch
Comment 6 Adrian Moser CLA 2011-10-13 05:04:45 EDT 
Created attachment 205105 [details]
Enhancements/fixes for the bookmark field.

Some more enhancements/fixes for the bookmark field (client-side only):
- allow dragging and transfer of multiple nodes
  (the current implementation allows selecting multiple nodes,
   but transfers only the first one)
- Possibility to use a row-level PublishUserBookmarkPermission
  (on a bookmark)
- Deletion of bookmark folders improved, 
  confirm message box shows list of bookmark/folders, 
  DeletionPermission for each bookmark is checked (Row-level)
- some more JavaDoc added.

No migration necessary, patch is expected to be fully backwards compatible.
Comment 7 Andi Bur CLA 2011-10-13 05:29:46 EDT 
Comment on attachment 205105 [details]
Enhancements/fixes for the bookmark field.

reviewed and applied patch
Comment 8 Andi Bur CLA 2012-03-22 14:09:29 EDT 
Changes have been applied.
Comment 9 Matthias Zimmermann CLA 2013-07-08 17:36:51 EDT 
Bugfixes shipped on Scout 3.7 branch