Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359314 - Use menus extension point instead of popupmenus
Summary: Use menus extension point instead of popupmenus
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.8 M3   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-28 18:03 EDT by Curtis Windatt CLA
Modified: 2011-10-25 14:37 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2011-09-28 18:03:27 EDT 
We are using the deprecated org.eclipse.ui.popupMenus extension point for our menu contributions (PDE Tools).  We should try and move as many as these items as we can over the the newer commands framework.
Comment 1 Remy Suen CLA 2011-09-28 18:11:22 EDT 
Didn't think this day would ever come.
Comment 2 Curtis Windatt CLA 2011-09-30 12:18:15 EDT 
Pushed a set of changes to replace the items in the PDE Tools menu.
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=9429b24e71ddab2aa04430f3c75ce8e3b1306ec4

There are still uses of popup menus (configuring jars into plug-ins) and view contribtions (log view) that I will try to find time to convert as well.
Comment 3 Curtis Windatt CLA 2011-10-03 15:28:33 EDT 
Would be nice to completely remove all use of the old style contributions, but there are more pressing bugs to look at for M3.  Marking as FIXED as the majority of contributions now use the commands framework and the remaining ones are functioning correctly.
Comment 4 Michael Rennie CLA 2011-10-12 13:35:38 EDT 
I am seeing the PDE Tools menu all over the place using:

Version: 3.8.0
Build id: I20111011-1046

Steps:
1. open the Ant view (remove all contents if any) -> right click -> PDE menu appears
2. open the Debug view -> right click -> PDE menu

Same holds true for Problems, Errors, Console and Variables view (to name a few)
Comment 5 Curtis Windatt CLA 2011-10-14 12:15:49 EDT 
Fixed in master.  When the expressions were moved to the definition extension point the featureFile definition's iterate was left at the default settings.  The default operator is 'and' which didn't hurt anything as there was another 'and' as a child.  However, the default 'ifEmpty' setting changes based on the operator, so the use of 'and' results in the setting being TRUE.
Comment 6 Curtis Windatt CLA 2011-10-25 14:37:14 EDT 
Verified in I20111021-1625

The icons make it easier to distinguish the actions (especially when the API Tools items are included).