Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359264 - Resource decorators broken for new folders and ignored files
Summary: Resource decorators broken for new folders and ignored files
Status: CLOSED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.1   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: 1.2   Edit
Assignee: Jens Baumgart CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-28 12:05 EDT by Markus Keller CLA
Modified: 2012-01-13 07:25 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-09-28 12:05:19 EDT 
1.2.0.201109261000, was OK in 1.1.0.201109151100-r

New folders in a Git project get the "tracked" icon, but they should get the "untracked" icon (empty folders as well as folders with contents).
Comment 1 Markus Keller CLA 2011-09-28 12:14:44 EDT 
As an intermediate state, I also saw whole projects (all files and folders) as untracked, but this was corrected after a while. I haven't seen this before with 1.1.0.201109151100-r.
Comment 2 Dani Megert CLA 2011-09-29 03:26:44 EDT 
I planned to upgrade from 1.1.0.201109151100-r to the latest build to verify some of the recently fixed bugs I filed, but this bug here scares me away from doing it.
Comment 3 Markus Keller CLA 2011-09-29 14:39:22 EDT 
In 1.2.0.201109290051, saw an even worse bug: The file /org.eclipse.swt/.classpath is not shared, but the decoration is "tracked" instead of "ignored".
Comment 4 Dani Megert CLA 2011-10-04 06:00:57 EDT 
Seems to work with 1.2.0.201110021920
Comment 5 Jens Baumgart CLA 2011-10-04 07:40:41 EDT 
1. Ignore state is missing in new decorator implementation

2. Decoration of untracked folders: this needs some rework, too.
Comment 6 Jens Baumgart CLA 2011-10-04 10:23:53 EDT 
Fix proposed for decoration of ignored files:
EGit: http://egit.eclipse.org/r/4323
JGit: http://egit.eclipse.org/r/4320
Comment 7 Matthias Sohn CLA 2011-10-11 17:40:54 EDT 
JGit change merged as 6befabcb1584118fb02188f602f7ca34b9a7efc5 
EGit change merged as 9e5ef8935c39247ae3d9fe6b92d2285bffa1c98d

Still decoration of untracked folders needs to be fixed
Comment 8 Dani Megert CLA 2011-10-22 02:15:48 EDT 
> Still decoration of untracked folders needs to be fixed

Yes, please. This is a very serious issue because one might think the project is clean (no outgoing changes) but it is not. This can e.g. cause conflicts when one tries to apply a patch. It is especially important because a hard reset does not clean the project and because EGit does not offer the clean operation yet.
Comment 9 Jens Baumgart CLA 2011-10-25 12:10:09 EDT 
Fixes proposed for decoration of untracked folders:

http://egit.eclipse.org/r/4406 (EGit)
http://egit.eclipse.org/r/4385 (JGit)
Comment 10 Matthias Sohn CLA 2011-11-23 17:27:35 EST 
(In reply to comment #9)
> Fixes proposed for decoration of untracked folders:
> 
> http://egit.eclipse.org/r/4406 (EGit)
merged as efce665800e3118ffc49fa11a5f004e749aa1441

> http://egit.eclipse.org/r/4385 (JGit)
merged as 53ef3e51145adb4b060110e262d7c064be0d5fc5
Comment 11 Dani Megert CLA 2011-11-28 05:48:33 EST 
Verified in 1.2.0.201111271913.
Comment 12 Dani Megert CLA 2011-11-28 10:04:37 EST 
Now, the remaining big problem is that the untracked decorator is not propagated to the parent folder/project (see bug 345099).
Comment 13 Jens Baumgart CLA 2012-01-13 07:25:15 EST 
I proposed a fix for the untracked issue in bug 345099.
I close this bug since the untracked issue is handled in bug 345099.