Community
Participate
Working Groups
Build id: I20110915-1308 The run to line action is enabled almost all the time, at least for the JDT debugger. There's a couple of reasons for this: 1) The retarget actions were redesigned with bug 180441 not to udpate with every selection change in editor. Instead, their enablement is controlled by whether a IRunToLineTarget adapter is available (i.e. IRunToLineTarget.canRunToLine() is not called). 2) JDT's canRunToLine() implementation does not check whether target is terminated. It should call canResume(). The latter problem is easy to take care of, the former is more complicated. Attached patch would fix the RetargetAction so that it would check action target's enablement upon active part change and debug context change, but it would not for editor selection change. It's a relatively risky change though as it affects the toggle breakpoint actions.
Created attachment 204126 [details] Changes to retarget action.
Created attachment 204127 [details] Fix for JDT's run to line target.
I committed the changes to the retarget action: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=0c5cbbd64f85f7684dd46ea34a9abb4247a3ca1b I also opened bug 360172 to fix JDT's IRunToLineTarget. After that we can add this action to the toolbar. Mike, please review.
+1 verified along with the fix for bug 360172
Verified in 4.2 I20111025-2000