Community
Participate
Working Groups
In content outline, when node-factory is added to a node and the node-factory's <property> element is set, the "move-up", "move-down" actions on the corresponding list don't refresh when the list property is changed. The root cause is inside OutlineNodeMoveActionHandler's init() method. It uses the following code to register a listener on the list property: getPart().getParentPart().getModelElement().addListener( this.listPropertyListener ); Here, getPart().getParentPart() would return an instance of MasterDetailsContentNode which doesn't supply its own getModelElement(). So SapphirePart's getModelElement() will be used. In this case, it'll return the parent element which doesn't contain the list property.
Created attachment 204128 [details] Fix
Looks good. Go ahead and commit it.
You must have gone home already. I will go ahead and commit this fix and you can verify.
Actually, the attached fix is only partially correct. The same change is needed during listener remove. Fixed in 0.3.1 and 0.4 lines. Please verify.
Verified the fix. Closing.