Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359145 - [Table] Typo in expression with property tester causing issues with handler enablement
Summary: [Table] Typo in expression with property tester causing issues with handler e...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-27 17:12 EDT by Alain Le Guennec CLA
Modified: 2020-05-01 11:26 EDT (History)
4 users (show)

See Also:
gdupe: kepler+

Attachments
Patch to fix the issue. (637 bytes, patch)
2011-09-27 17:14 EDT, Alain Le Guennec CLA 		gdupe: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alain Le Guennec CLA 2011-09-27 17:12:43 EDT 
There seems to be a typo in org.eclipse.emf.facet.widgets.nattable/plugin.xml in the enableWith expression for the loadFacetCommand handler:
It currently reads:
property="org.eclipse.emf.facet.widgets.nattable.workbencattable.workbench.tableSelectionTester.isTable"
                                                 ^^^^^^^^^^^^^^^
The strange "workbencattable" part should be removed.
Otherwise, this cause the right property tester not to be found.
Comment 1 Alain Le Guennec CLA 2011-09-27 17:14:04 EDT 
Created attachment 204119 [details]
Patch to fix the issue.
Comment 2 Nicolas Bros CLA 2011-09-30 10:17:47 EDT 
Thank you for this bug.
Fixed in revisions 893 & 895 on trunk and branch 0_1.
Comment 3 Alain Le Guennec CLA 2011-10-02 11:53:27 EDT 
Actually, my patch was slightly wrong:
To test against the "activePart" property, one should not use property tester "org.eclipse.emf.facet.widgets.nattable.workbench.tableSelectionTester.isTable", but "org.eclipse.emf.facet.widgets.nattable.workbench.tablePartTester.isTableEditor",
otherwise expression evaluation will fail with some CoreExceptions being raised..
Sorry for misleading you with a wrong patch.
Comment 4 Nicolas Bros CLA 2011-10-03 03:45:04 EDT 
The fix seems to work for me: I don't see any error and the "Load Facet" action is enabled when the table editor is active.

What do you do to trigger a CoreException?
Comment 5 Gregoire Dupe CLA 2013-05-23 07:55:55 EDT 
Comment on attachment 204119 [details]
Patch to fix the issue.

This patch has been committed by Nicolas Bros.
Comment 6 Gregoire Dupe CLA 2013-05-23 09:16:10 EDT 
I've to close this bug to be able to the contribution in the IP log.

If needed, please, open another bug.