Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359131 - Fixing the dual-monitor issue has broken two tests
Summary: Fixing the dual-monitor issue has broken two tests
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.2 M3   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-27 15:21 EDT by Eric Moffatt CLA
Modified: 2011-10-26 13:42 EDT (History)
1 user (show)

See Also:

Attachments
Change the tests to ensure the modelled window has both a width and height (1.44 KB, patch)
2011-09-27 15:31 EDT, Eric Moffatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2011-09-27 15:21:11 EDT 
testWindow_X and testWindowY are broken now. This is the result of the fix for bug 358627. I've added code to force the shell back into the display if the following test fails:

modelBounds.intersects(displayBounds)

Unfortunately it appears that rectangles that have zero width and zero height don't 'intersect' anything...
Comment 1 Eric Moffatt CLA 2011-09-27 15:31:35 EDT 
Created attachment 204115 [details]
Change the tests to ensure the modelled window has both a width and height


Remy, take a look. If you think that these changes invalidate the tests then let's talk about it, I could likely come up with logic that doesn't need 'intersects' if we think it's an issue...
Comment 2 Remy Suen CLA 2011-09-27 16:17:43 EDT 
(In reply to comment #1)
> Created attachment 204115 [details]
> Change the tests to ensure the modelled window has both a width and height

This looks okay to me.
Comment 3 Eric Moffatt CLA 2011-09-27 16:19:50 EDT 
Pushed in >20110927.

commit c7d2276fad5ddc346e18590c8db21f269165d00c
Comment 4 Eric Moffatt CLA 2011-10-26 13:42:27 EDT 
Verified in I20111025-2000.