Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359129 - Replace/Append buttons in launch configuration's environment tab are confusing
Summary: Replace/Append buttons in launch configuration's environment tab are confusing
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: RDT (show other bugs)
Version: 5.0.1   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 5.0.5   Edit
Assignee: Greg Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-27 15:13 EDT by Corey Ashford CLA
Modified: 2012-05-23 16:55 EDT (History)
0 users

See Also:


Attachments
Adds a tool tip to inform the user that the setting is not alterable (3.77 KB, patch)
2011-09-27 17:27 EDT, Corey Ashford CLA
no flags Details | Diff
Add tooltip to describe that the Replace/Append mode is fixed (2.77 KB, patch)
2011-09-27 18:10 EDT, Corey Ashford CLA
g.watson: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Corey Ashford CLA 2011-09-27 15:13:50 EDT
Build Identifier: I20110613-1736

There are two radio buttons in the Environment tab of the launch configuration.  The class that implements this tab permanently grays these buttons out so that they cannot be changed.

This is confusing, because usually there's a way to enable grayed-out buttons if something is set correctly.  For example, under a local launch configuration, the buttons are enabled once any environment variables are added to the table.

But for RDT, there's no way to enable them.  I would prefer that a message is added saying something to the effect:
"Any environment variables specified above are always appended to the native environment."


Reproducible: Always

Steps to Reproduce:
1.Right click on an executable in a remote project
2.Select "Run As" -> "Run Configurations..."-> "Parallel Application" click new, then click the Environment tab
3. Notice the Append and Replace buttons are permanently grayed out.
Comment 1 Corey Ashford CLA 2011-09-27 17:27:53 EDT
Created attachment 204122 [details]
Adds a tool tip to inform the user that the setting is not alterable

This patch adds a tool tip to the composite containing the two radio buttons.  The tool tip tells the user that the Append/Replace setting cannot be altered for this particular launcher.

Note that the composite object is a local variable in the superclass, so I had to override the whole method in order to add the tool tip.

This patch contains only about 30 lines of code.
Comment 2 Corey Ashford CLA 2011-09-27 18:10:12 EDT
Created attachment 204125 [details]
Add tooltip to describe that the Replace/Append mode is fixed

This patch adds a tool tip to the composite which contains the Replace/Append
radio buttons (which are disabled).  The tool tip explains that the setting
cannot be modified in this launcher.

(Note: this is a simpler version of the original patch.  I used "getParent()" to
get the composite containing the buttons, rather than overriding the method
which creates the buttons.)
Comment 3 Greg Watson CLA 2012-02-14 12:31:42 EST
Applied to ptp_5_0 and master. Thanks!