Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359117 - [Compatibility] Separators don't show up for .ecorediagram files
Summary: [Compatibility] Separators don't show up for .ecorediagram files
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M7   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331377
  Show dependency tree
 
Reported: 2011-09-27 13:08 EDT by Remy Suen CLA
Modified: 2012-05-01 12:38 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-09-27 13:08:56 EDT 
When a .ecorediagram file is opened, there should be several separators in the main toolbar. They are not being rendered right now.

See attachment 203658 [details] for reference.
Comment 1 Remy Suen CLA 2011-09-27 13:32:51 EDT 
The SeparatorRenderer is not capable of handling incremental additions. When a separator is appended to the end of the list, it interprets itself as the final separator and as a result does not need to be rendered. While this logic is valid for this single operation, the assumption becomes void once another non-separator item is appended at the end. Now that there _is_ another item between the separator and the end, the separator _needs_ to be rendered.
Comment 2 Remy Suen CLA 2011-10-03 13:29:05 EDT 
Even if I change the renderer to create separators they don't seem to be showing up in the UI so maybe I'm barking up the wrong tree.
Comment 3 Curtis Windatt CLA 2012-04-19 11:33:33 EDT 
This is not fixed using the latest UI code from master and e4.tools 0.10.0.20120203135.
Comment 5 Curtis Windatt CLA 2012-05-01 12:38:58 EDT 
Verified in I20120430-1800
Bug 377961 is still a problem