Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359082 - ToolBarManagerRenderer$6.changed() takes up ~25% of the time when opening & closing views
Summary: ToolBarManagerRenderer$6.changed() takes up ~25% of the time when opening & c...
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 358490
  Show dependency tree
 
Reported: 2011-09-27 10:43 EDT by Oleg Besedin CLA
Modified: 2012-03-28 14:44 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Besedin CLA 2011-09-27 10:43:22 EDT
ToolBarManagerRenderer$6.changed() takes up 25 - 30% of the CPU time when opening & closing views.

processAddition() :
parentContext.runAndTrack(new RunAndTrack() {
	@Override
	public boolean changed(IEclipseContext context) {
		record.updateVisibility(parentContext.getActiveLeaf());
		manager.update(true);
		// disposeToolbarIfNecessary(toolbarModel);
		return true;
	}
});

There is also similar MenuManagerRenderer$6.changed(), that seems to be taking up somewhere in the range of 5% - 10%.
Comment 1 Oleg Besedin CLA 2012-03-28 14:44:04 EDT
The time is currently down to about 10 - 15% which is probably as good as it will get for 4.2.