Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 359038 - Allow to copy commit hash via context menu > Copy
Summary: Allow to copy commit hash via context menu > Copy
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.3   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-27 06:51 EDT by Dani Megert CLA
Modified: 2012-01-23 03:31 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-09-27 06:51:07 EDT 
1.1.0.201109151100-r.

I can copy the commit hash from the Commit Editor or from the History view via keyboard but not via mouse. As a mouse user I'd like to be able to do right mouse click > Copy.
Comment 1 Dani Megert CLA 2011-11-23 04:54:17 EST 
Pushed http://egit.eclipse.org/r/4669 for review.
Comment 2 Markus Keller CLA 2011-12-05 05:33:57 EST 
Re enablement problems discussed in http://egit.eclipse.org/r/#change,4669 :
This is not Mac-specific.

Steps to reproduce are:
- select the SHA
=> Copy is enabled (good)
- click into Message field
- right-click the title field
=> Copy enabled (should be disabled)

The problem is that HeaderText(Form, String) contains
			titleLabel.addFocusListener(new FocusAdapter() {
				public void focusLost(FocusEvent e) {
					titleLabel.setSelection(0);
				}
			});

This changes the selection without notifying selection listeners.
Comment 3 Dani Megert CLA 2011-12-05 06:00:25 EST 
(In reply to comment #2)
> Re enablement problems discussed in http://egit.eclipse.org/r/#change,4669 :
> This is not Mac-specific.
> 
> Steps to reproduce are:
> - select the SHA
> => Copy is enabled (good)
> - click into Message field
> - right-click the title field
> => Copy enabled (should be disabled)
> 
> The problem is that HeaderText(Form, String) contains
>             titleLabel.addFocusListener(new FocusAdapter() {
>                 public void focusLost(FocusEvent e) {
>                     titleLabel.setSelection(0);
>                 }
>             });
> 
> This changes the selection without notifying selection listeners.

Thanks for checking.
Comment 4 Matthias Sohn CLA 2012-01-20 19:27:45 EST 
merged as 5922341006cdaffcf83f034cb6bbb063ae499ee6
Comment 5 Dani Megert CLA 2012-01-23 03:31:59 EST 
Verified in org.eclipse.egit.ui_1.3.0.201201221914.