Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358991 - Reference should be removed
Summary: Reference should be removed
Status: CLOSED INVALID
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Yun Feng Ma CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-26 22:19 EDT by Lu Yao CLA
Modified: 2017-02-23 14:17 EST (History)
5 users (show)

See Also:

Attachments
Patch (3.03 KB, patch)
2011-09-29 04:14 EDT, Yun Feng Ma CLA 		no flags Details | Diff
New Patch (4.82 KB, patch)
2011-09-29 04:28 EDT, Yun Feng Ma CLA 		no flags Details | Diff
Patch (3.03 KB, patch)
2011-10-10 05:05 EDT, Yun Feng Ma CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lu Yao CLA 2011-09-26 22:19:07 EDT 
Build Identifier: 0926

reference, menu, source editor

Reproducible: Always

Steps to Reproduce:
1. In source editor, right click, the item Reference should be removed.
2.
3.
Comment 1 Yun Feng Ma CLA 2011-09-29 04:14:30 EDT 
Created attachment 204263 [details]
Patch

Here is a patch.
Comment 2 Yun Feng Ma CLA 2011-09-29 04:28:21 EDT 
Created attachment 204266 [details]
New Patch

A new patch.
Comment 3 Yun Feng Ma CLA 2011-09-29 05:32:18 EDT 
Resolved.
Comment 4 Brian Svihovec CLA 2011-09-29 14:16:05 EDT 
Can you provide some details regarding the reason that these menu options were removed?  

In RBD, the References and Declarations menu options were used as a quick way to invoke an EGL Search on the selected item.  Were these removed because the underlying support for this type of search not implemented yet in EDT?  If that is the case, is there a work item to re-enable these menu options?
Comment 5 Justin Spadea CLA 2011-09-29 14:29:17 EDT 
Also, if we decide to keep this change, I'm seeing the following in the console:

!MESSAGE Cannot bind to an undefined command: plug-in='org.eclipse.edt.ide.ui', id='org.eclipse.edt.ide.ui.search.findWorkspaceReferences'
!MESSAGE Cannot bind to an undefined command: plug-in='org.eclipse.edt.ide.ui', id='org.eclipse.edt.ide.ui.search.findWorkspaceDeclarations'
Comment 6 Brian Svihovec CLA 2011-10-07 11:07:22 EDT 
Reopening due to outstanding comments.
Comment 7 Yun Feng Ma CLA 2011-10-10 05:05:16 EDT 
Created attachment 204860 [details]
Patch

Hi Brian and Justin,

I talked this with Yao and Xiao Bin, looks like these functions don't work for variables in EGL editor, maybe that's an ehancement. I will bring back these menus now. Thanks.
Comment 8 Yun Feng Ma CLA 2011-10-10 05:12:53 EDT 
Resolve this bug as invalid. Thanks.
Comment 9 Justin Spadea CLA 2011-10-10 08:51:21 EDT 
I don't think it has ever supported variables, but that would be a good enhancement for the future.
Comment 10 Lu Yao CLA 2011-10-13 02:54:25 EDT 
it works on b 1011