Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358979 - [github] Include commit comments in pull request comments list
Summary: [github] Include commit comments in pull request comments list
Status: ASSIGNED
Alias: None
Product: EGit
Classification: Technology
Component: GitHub (show other bugs)
Version: 1.1   Edit
Hardware: PC Linux
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Kevin Sawicki CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-26 18:16 EDT by Robert Munteanu CLA
Modified: 2016-09-13 18:08 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Munteanu CLA 2011-09-26 18:16:00 EDT 
Opening https://github.com/mantisbt/mantisbt/pull/15 in the web interface shows three comments, but the task editor only shows the second and third one.
Comment 1 Chris Aniszczyk CLA 2011-09-26 18:16:34 EDT 
Kevin?
Comment 2 Kevin Sawicki CLA 2011-09-26 18:29:47 EDT 
The first comment on that pull request is a commit comment, not a regular pull request comment.

The pull request editor does not currently show comments on commits or diffs.
Comment 3 Robert Munteanu CLA 2011-09-27 02:45:44 EDT 
(In reply to comment #2)
> The first comment on that pull request is a commit comment, not a regular pull
> request comment.
> 
> The pull request editor does not currently show comments on commits or diffs.

Thanks for the clarification. I've reworded this report as an enhancement ; I feel that this is important since the flow of comments was broken and I had no idea why.
Comment 4 Kevin Sawicki CLA 2011-09-27 11:23:47 EDT 
Yes, you are absolutely right, it does break the flow of comments when they are missing.