Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358973 - Sapphire diagram should not persist Graphiti's EMF based diagram model
Summary: Sapphire diagram should not persist Graphiti's EMF based diagram model
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Sapphire (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Shenxue Zhou CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-26 16:43 EDT by Shenxue Zhou CLA
Modified: 2021-11-19 09:22 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shenxue Zhou CLA 2011-09-26 16:43:05 EDT 
Sapphire diagram editor uses Sapphire model and it saves node/connection layout info in a .layout file. When the diagram editor is open, it actually reconstructs the diagram using the Sapphire model and the layout file. EMF based diagram model used by Graphiti is not really needed.

We should attempt to remove the .xml file corresponding to the Graphiti diagram model. It's not only inefficient but also creates maintainence issues with the additional file. For example, when a diagram is being edited, if the .xml file is accidentally deleted, then the diagram editor would enter into an unusable state.
Comment 1 Shenxue Zhou CLA 2011-09-26 17:22:09 EDT 
Fixed by using a "virtual" uri for the Graphiti diagram model
Comment 2 Shenxue Zhou CLA 2011-09-26 17:27:21 EDT 
Developer should no longer see the .xmi file in the .settings folder
Comment 3 Raj Alagumalai CLA 2011-09-27 11:58:37 EDT 
verified with 0.3.1.201109261654
Comment 4 Shenxue Zhou CLA 2011-09-27 12:10:35 EDT 
Closing based on Raj's verification.