Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 358963 - Goto line key binding should not use prompt
Summary: Goto line key binding should not use prompt
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Editor (show other bugs)
Version: 0.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 0.4 M1   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 342739
Blocks:
  Show dependency tree
 
Reported: 2011-09-26 15:05 EDT by Silenio Quarti CLA
Modified: 2011-11-15 12:36 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Silenio Quarti CLA 2011-09-26 15:05:40 EDT
The prompt dialog opened by goto line is very annoying.  We should use something similar to the editor search field or the incremental find.
Comment 1 Susan McCourt CLA 2011-11-11 13:55:21 EST
I'm working on this, but not done yet.
In the lower level TextActions, we don't have knowledge of the outer page, so window prompt is going to have to be there.

But up in editorCommands, we can use the command parameter stuff to get the parameter with a slideout, much like find and replace.  As a first step I added  "goto line" to the editor toolbar.  When invoked from the command, the right thing happens (no prompt, just a little slide out). 

What I still need to do (next week) is to override the editor keybinding to do the command/parameter invocation rather than the underlying TextActions implementation.  For this to work, there is some cleanup I need to do in the command framework to gather the right parameters (such as command dom ids) that are needed when the command executes from a keybinding.
Comment 2 Susan McCourt CLA 2011-11-15 12:36:46 EST
fixed.